feat: removed enable_moderation_reason_codes flag #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhtishamShahid
force-pushed
the
ahtisham/INF-1159
branch
from
8256bbe
to
d57726e
Compare
fix: resolved linter error fix: changed workflow fix: changed workflow fix: changed workflow fix: changed workflow fix: changed workflow fix: changed workflow fix: changed workflow fix: changed workflow fix: changed workflow fix: changed workflow fix: changed workflow fix: changed workflow
AhtishamShahid
force-pushed
the
ahtisham/INF-1159
branch
from
894b7c6
to
1c2d4b4
Compare
sundasnoreen12
previously approved these changes
Dec 1, 2023
There was a problem hiding this comment.
PR LGTM. @AhtishamShahid please check test cases are failing.
sundasnoreen12
dismissed
their stale review
I'll review again once the failed test cases will pass.
awais-ansari
changed the title
awais-ansari
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
==========================================
- Coverage 92.37% 92.36% -0.02%
==========================================
Files 169 169
Lines 3450 3445 -5
Branches 898 897 -1
==========================================
- Hits 3187 3182 -5
Misses 243 243
Partials 20 20 ☔ View full report in Codecov by Sentry. |
awais-ansari
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description.
Deprecated enable_moderation_reason_codes flag from the discussion app
Ticket
https://2u-internal.atlassian.net/browse/INF-1159