feat: Add support for grouping at subsections [BD-38] #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @xitij2000! When this pull request is ready, tag your edX technical lead. |
openedx-webhooks
added
the
blended
xitij2000
added a commit
to open-craft/frontend-app-learning
that referenced
this pull request
Sep 6, 2022
To enable grouping by subsection in the discussions MFE, this PR updates the embed URL to the one that supports grouping. ref: openedx/frontend-app-discussions#281
Codecov ReportBase: 84.29% // Head: 84.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
+ Coverage 84.29% 84.44% +0.15%
==========================================
Files 131 131
Lines 2521 2540 +19
Branches 673 679 +6
==========================================
+ Hits 2125 2145 +20
+ Misses 373 372 -1
Partials 23 23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xitij2000
added a commit
to open-craft/frontend-app-learning
that referenced
this pull request
Sep 8, 2022
To enable grouping by subsection in the discussions MFE, this PR updates the embed URL to the one that supports grouping. ref: openedx/frontend-app-discussions#281
xitij2000
force-pushed
the
kshitij/group-at-subsection
branch
2 times, most recently
from
f831c8a to
a74b54f
Compare
tecoholic
approved these changes
Sep 16, 2022
Contributor
tecoholic
left a comment
tecoholic
left a comment
There was a problem hiding this comment.
- I tested this: Setup both learning MFE and discussion MFE branches, enabled in-context and subsection grouping and verified that discussion topics from other units from the same sub-section are shown (See attached image)
- I read through the code
- I checked for accessibility issues
- Includes documentation
mehaknasir
approved these changes
Oct 7, 2022
Contributor
|
@xitij2000 can you please rebase it? I have tested and approved this PR. |
Contributor
|
just a side test case is on click add post button FE crashes in your branch on selectTopic selector. please handle that before you merge |
For smaller courses, there is a feature under the new provider for grouping topics at the subsection level so that when navigating the course, all topics under a subsection show up in the sidebar instead of just the current unit. This implements that functionality by checking if the discussion is loaded in-context, and if grouping at subsection is enabled, and if so, displaying the current subsection's topics.
xitij2000
force-pushed
the
kshitij/group-at-subsection
branch
from
a74b54f to
ff95b00
Compare
saadyousafarbi
pushed a commit
to openedx/frontend-app-learning
that referenced
this pull request
Oct 12, 2022
…968) To enable grouping by subsection in the discussions MFE, this PR updates the embed URL to the one that supports grouping. ref: openedx/frontend-app-discussions#281
|
@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
arbrandes
pushed a commit
to openedx/frontend-app-learning
that referenced
this pull request
Nov 14, 2022
…968) To enable grouping by subsection in the discussions MFE, this PR updates the embed URL to the one that supports grouping. ref: openedx/frontend-app-discussions#281
moonesque
pushed a commit
to edSPIRIT/frontend-app-discussions
that referenced
this pull request
Nov 12, 2023
…penedx#281) * feat: add reported email notifications setting in legacy discussions * feat: display reported content email notification based on a flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For smaller courses, there is a feature under the new provider
for grouping topics at the subsection level so that when
navigating the course, all topics under a subsection show up in
the sidebar instead of just the current unit.
This implements that functionality by checking if the discussion
is loaded in-context, and if grouping at subsection is enabled,
and if so, displaying the current subsection's topics.