Skip to content

Conversation

@bradenmacdonald
Copy link
Contributor

Implements openedx/modular-learning#191

Depends on openedx/openedx-learning#156

This updates the UI to display the total number of descendant tags for each tag, not just the direct number of children.

Before After
before after

Private ref: FAL-3655

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 7, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@bradenmacdonald bradenmacdonald changed the title Display full descendant count on taxonomy tag list page Display full descendant count on taxonomy tag list page [FC-0036] Feb 7, 2024
@bradenmacdonald bradenmacdonald force-pushed the braden/inclusive-counts branch from 26bbd34 to 5672b86 Compare February 7, 2024 21:12
@codecov
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b234344) 89.02% compared to head (84d4363) 89.02%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #826   +/-   ##
=======================================
  Coverage   89.02%   89.02%           
=======================================
  Files         545      545           
  Lines        9585     9585           
  Branches     2054     2054           
=======================================
  Hits         8533     8533           
  Misses       1005     1005           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with one test request.

  • I tested this on my devstack with openedx/openedx-learning#156
    • Navigated to the taxonomies list and selected a taxonomy
    • Ensured that the descendant counts are showing as expected next to each tag in the tree.
  • I read through the code
  • I checked for accessibility issues by using my keyboard to navigate.
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

@bradenmacdonald bradenmacdonald force-pushed the braden/inclusive-counts branch from 5672b86 to 84d4363 Compare February 8, 2024 19:28
Copy link
Contributor

@xitij2000 xitij2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@xitij2000 xitij2000 merged commit 16d2f38 into openedx:master Feb 20, 2024
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@xitij2000 xitij2000 deleted the braden/inclusive-counts branch February 20, 2024 10:10
@bradenmacdonald
Copy link
Contributor Author

Thanks @xitij2000 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants