-
Notifications
You must be signed in to change notification settings - Fork 172
feat: migration filter and search bar in legacy libraries tab [FC-0097] #2421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
f24e1e9 to
e7b21fa
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2421 +/- ##
========================================
Coverage 94.64% 94.65%
========================================
Files 1196 1196
Lines 26467 26514 +47
Branches 5750 5913 +163
========================================
+ Hits 25050 25097 +47
+ Misses 1358 1347 -11
- Partials 59 70 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a885b7e to
36db26b
Compare
rpenido
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you for your work, @navinkarkera!
- I tested this using the instructions from the PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
| function findInValues<T extends {}>(arr: T[] | undefined, value: string) { | ||
| return arr?.filter(o => Object.entries(o).some(entry => String(entry[1]).toLowerCase().includes( | ||
| String(value).toLowerCase().trim(), | ||
| ))); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, since we don't use the key here:
| function findInValues<T extends {}>(arr: T[] | undefined, value: string) { | |
| return arr?.filter(o => Object.entries(o).some(entry => String(entry[1]).toLowerCase().includes( | |
| String(value).toLowerCase().trim(), | |
| ))); | |
| } | |
| function findInValues<T extends {}>(arr: T[] | undefined, searchValue: string) { | |
| return arr?.filter(o => Object.values(o).some(value => String(value).toLowerCase().includes( | |
| String(searchValue).toLowerCase().trim(), | |
| ))); | |
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
36db26b to
0a0efa5
Compare
c056392 to
cf6b358
Compare
cf6b358 to
995360e
Compare
995360e to
7d50ddd
Compare
|
@ChrisChV Resolved conflicts! Ready to be merged. |
ChrisChV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for all this work!!
Description
Adds search bar and migration filter in legacy libraries tab.
Useful information to include:
Supporting information
Private-ref: https://tasks.opencraft.com/browse/FAL-4237Testing instructions
Other information
Review only last 5 commits.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'