Skip to content

Conversation

@navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Sep 3, 2025

Description

Adds search bar and migration filter in legacy libraries tab.

Useful information to include:

  • Which user roles will this change impact? Course Author.
image

Supporting information

Testing instructions

Other information

Review only last 5 commits.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Sep 3, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 3, 2025

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.65%. Comparing base (2516034) to head (7d50ddd).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...c/studio-home/tabs-section/libraries-tab/index.tsx 96.29% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2421    +/-   ##
========================================
  Coverage   94.64%   94.65%            
========================================
  Files        1196     1196            
  Lines       26467    26514    +47     
  Branches     5750     5913   +163     
========================================
+ Hits        25050    25097    +47     
+ Misses       1358     1347    -11     
- Partials       59       70    +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@navinkarkera navinkarkera force-pushed the navin/FAL-4237/filter-ui branch 2 times, most recently from a885b7e to 36db26b Compare September 4, 2025 14:31
@navinkarkera navinkarkera changed the title feat: migration filter and search bar in legacy libraries tab feat: migration filter and search bar in legacy libraries tab [FC-0097] Sep 4, 2025
Copy link
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work, @navinkarkera!

  • I tested this using the instructions from the PR
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Comment on lines 16 to 20
function findInValues<T extends {}>(arr: T[] | undefined, value: string) {
return arr?.filter(o => Object.entries(o).some(entry => String(entry[1]).toLowerCase().includes(
String(value).toLowerCase().trim(),
)));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, since we don't use the key here:

Suggested change
function findInValues<T extends {}>(arr: T[] | undefined, value: string) {
return arr?.filter(o => Object.entries(o).some(entry => String(entry[1]).toLowerCase().includes(
String(value).toLowerCase().trim(),
)));
}
function findInValues<T extends {}>(arr: T[] | undefined, searchValue: string) {
return arr?.filter(o => Object.values(o).some(value => String(value).toLowerCase().includes(
String(searchValue).toLowerCase().trim(),
)));
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@navinkarkera navinkarkera force-pushed the navin/FAL-4237/filter-ui branch from 36db26b to 0a0efa5 Compare September 5, 2025 05:36
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Sep 10, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Sep 10, 2025
@navinkarkera navinkarkera force-pushed the navin/FAL-4237/filter-ui branch 2 times, most recently from c056392 to cf6b358 Compare September 25, 2025 06:06
@navinkarkera navinkarkera marked this pull request as ready for review September 25, 2025 06:15
@navinkarkera navinkarkera force-pushed the navin/FAL-4237/filter-ui branch from cf6b358 to 995360e Compare September 25, 2025 16:13
@navinkarkera navinkarkera force-pushed the navin/FAL-4237/filter-ui branch from 995360e to 7d50ddd Compare September 25, 2025 16:15
@navinkarkera
Copy link
Contributor Author

@ChrisChV Resolved conflicts! Ready to be merged.

Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for all this work!!

@ChrisChV ChrisChV enabled auto-merge (squash) September 25, 2025 16:29
@ChrisChV ChrisChV merged commit cffc4d7 into openedx:master Sep 25, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants