-
Notifications
You must be signed in to change notification settings - Fork 172
feat: add library v2 alert [FC-0097] #2413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add library v2 alert [FC-0097] #2413
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2413 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 1196 1197 +1
Lines 26514 26529 +15
Branches 5915 5936 +21
=======================================
+ Hits 25097 25112 +15
Misses 1347 1347
Partials 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
6d8e762 to
c838121
Compare
d2ad01e to
62b3294
Compare
navinkarkera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpenido Looks good 👍, Just some minor nits.
- I tested this: (Verified alert behaviour in v2 libraries tab)
- I read through the code
- I checked for accessibility issues
- Includes documentation
src/studio-home/tabs-section/libraries-v2-tab/WelcomeLibrariesV2Alert.tsx
Outdated
Show resolved
Hide resolved
src/studio-home/tabs-section/libraries-v2-tab/WelcomeLibrariesV2Alert.tsx
Outdated
Show resolved
Hide resolved
0462f4e to
ea4e51f
Compare
ea4e51f to
4bceca0
Compare
Description
This PR adds an Alert to the Legacy Library Page to notify the user of the process of deprecating Legacy Libraries and a Button to open the Migrate Library interface.
Before
After (with pending migrations)
After (without pending migrations)
"Course Author",
Supporting information
Testing instructions
The alert has two states, so uncomment the code below and switch
isMigratedtotrue/falseto check both states.frontend-app-authoring/src/studio-home/data/apiHooks.ts
Lines 17 to 20 in 62b3294
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'Private ref: FAL-4234