Skip to content

Conversation

@awais-ansari
Copy link
Contributor

  1. Data and Time field works for the latest version of browsers and restricts the user to enter invalid dates and times.
  2. I added date and time validation for non supported browsers.
  3. User is allowed to enter dates in 2 formats ['YYYY-MM-DD', 'MM/DD/YYYY'] in non-supported browsers which will make validation smooth on both platforms.
  4. User is allowed to enter time in 2 formats ['HH:mm', 'hh:mm A'] (24 hours, 12 hours) in non-supported browsers which will make validation smooth on both platforms.

Screenshot 2021-10-21 at 4 25 16 PM

Screenshot 2021-10-21 at 4 25 45 PM

Screenshot 2021-10-21 at 4 27 00 PM

Screenshot 2021-10-21 at 4 39 27 PM

Screenshot 2021-10-21 at 4 40 00 PM

Copy link
Contributor

@awaisdar001 awaisdar001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some questions & nits.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021

Codecov Report

Merging #203 (baaab84) into master (9fd6cbf) will decrease coverage by 0.53%.
The diff coverage is 29.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage   66.54%   66.00%   -0.54%     
==========================================
  Files          93       93              
  Lines        1647     1674      +27     
  Branches      355      364       +9     
==========================================
+ Hits         1096     1105       +9     
- Misses        532      544      +12     
- Partials       19       25       +6     
Impacted Files Coverage Δ
...s/app-config-form/apps/legacy/LegacyConfigForm.jsx 72.72% <0.00%> (-3.47%) ⬇️
...iscussions/app-config-form/apps/shared/messages.js 100.00% <ø> (ø)
src/pages-and-resources/discussions/data/api.js 91.89% <0.00%> (+2.41%) ⬆️
src/utils.js 30.76% <14.28%> (-7.53%) ⬇️
...and-resources/discussions/app-config-form/utils.js 36.53% <57.14%> (+7.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd6cbf...baaab84. Read the comment docs.

Copy link
Contributor

@awaisdar001 awaisdar001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some questions here.

@awais-ansari awais-ansari merged commit bfda00a into master Oct 25, 2021
@awais-ansari awais-ansari deleted the aansari/TNL-8804 branch October 25, 2021 14:16
cgaber2045 pushed a commit to cgaber2045/frontend-app-course-authoring that referenced this pull request Jan 14, 2022
…x#203)

* fix: add blackout dates validation for non supported browsers

* refactor: update functions name
bradenmacdonald pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Aug 9, 2024
* fix: fix border and allow customizing of tinymce style

* fix: make tinymce widget look like on figma

* fix: update settingsoptions card border

* fix: header typography

* fix: spacings

* chore: update snapshots

* Update src/editors/containers/ProblemEditor/components/EditProblemView/SettingsWidget/index.jsx

Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com>

* Update src/editors/containers/ProblemEditor/components/EditProblemView/SettingsWidget/index.jsx

Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com>

* Update src/editors/containers/ProblemEditor/components/EditProblemView/index.jsx

Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com>

* Update src/editors/containers/ProblemEditor/components/EditProblemView/QuestionWidget/index.jsx

Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com>

* Update src/editors/containers/ProblemEditor/components/EditProblemView/QuestionWidget/index.jsx

Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com>

* Update src/editors/containers/ProblemEditor/components/EditProblemView/QuestionWidget/index.jsx

Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com>

* fix: html and react problems in problem editor

* chore: update snapshots

* chore: apply pr suggestions

* chore: fix test coverage

* chore: fix lint

* chore: fix tests

* chore: fix lint

Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants