-
Notifications
You must be signed in to change notification settings - Fork 164
fix: add blackout dates validation for non supported browsers #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
awais-ansari
commented
Oct 21, 2021
- Data and Time field works for the latest version of browsers and restricts the user to enter invalid dates and times.
- I added date and time validation for non supported browsers.
- User is allowed to enter dates in 2 formats ['YYYY-MM-DD', 'MM/DD/YYYY'] in non-supported browsers which will make validation smooth on both platforms.
- User is allowed to enter time in 2 formats ['HH:mm', 'hh:mm A'] (24 hours, 12 hours) in non-supported browsers which will make validation smooth on both platforms.





src/pages-and-resources/discussions/app-config-form/apps/legacy/LegacyConfigForm.jsx
Outdated
Show resolved
Hide resolved
awaisdar001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some questions & nits.
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
- Coverage 66.54% 66.00% -0.54%
==========================================
Files 93 93
Lines 1647 1674 +27
Branches 355 364 +9
==========================================
+ Hits 1096 1105 +9
- Misses 532 544 +12
- Partials 19 25 +6
Continue to review full report at Codecov.
|
src/pages-and-resources/discussions/app-config-form/apps/legacy/LegacyConfigForm.jsx
Show resolved
Hide resolved
awaisdar001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some questions here.
…x#203) * fix: add blackout dates validation for non supported browsers * refactor: update functions name
* fix: fix border and allow customizing of tinymce style * fix: make tinymce widget look like on figma * fix: update settingsoptions card border * fix: header typography * fix: spacings * chore: update snapshots * Update src/editors/containers/ProblemEditor/components/EditProblemView/SettingsWidget/index.jsx Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> * Update src/editors/containers/ProblemEditor/components/EditProblemView/SettingsWidget/index.jsx Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> * Update src/editors/containers/ProblemEditor/components/EditProblemView/index.jsx Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> * Update src/editors/containers/ProblemEditor/components/EditProblemView/QuestionWidget/index.jsx Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> * Update src/editors/containers/ProblemEditor/components/EditProblemView/QuestionWidget/index.jsx Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> * Update src/editors/containers/ProblemEditor/components/EditProblemView/QuestionWidget/index.jsx Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> * fix: html and react problems in problem editor * chore: update snapshots * chore: apply pr suggestions * chore: fix test coverage * chore: fix lint * chore: fix tests * chore: fix lint Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com>