-
Notifications
You must be signed in to change notification settings - Fork 119
fix: rename library publish button [teak] #2015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename library publish button [teak] #2015
Conversation
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/teak #2015 +/- ##
===============================================
Coverage ? 93.81%
===============================================
Files ? 1147
Lines ? 23989
Branches ? 5177
===============================================
Hits ? 22505
Misses ? 1416
Partials ? 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ab9e3fc
to
2c74281
Compare
2c74281
to
9849d5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
- I tested this: I verified the new text of the publish button
- I read through the code and considered the security, stability and performance implications of the changes.
- I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
- Includes documentation
CC @farhaanbukhsh on this backport |
Description
Backport of #1993 and #2016
Supporting information
Testing instructions
Check #2016
Private ref: FAL-4160