-
Notifications
You must be signed in to change notification settings - Fork 119
fix: removing edX text reference on video fallback message #1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: removing edX text reference on video fallback message #1996
Conversation
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1996 +/- ##
==========================================
+ Coverage 93.90% 93.93% +0.03%
==========================================
Files 1153 1154 +1
Lines 24053 24073 +20
Branches 5198 5094 -104
==========================================
+ Hits 22586 22614 +28
+ Misses 1399 1391 -8
Partials 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
254dcd5
to
3a125bf
Compare
3a125bf
to
0525586
Compare
Description
Updating video fallback message to remove edX reference.
Supporting information
#1015
openedx/wg-build-test-release#491
Testing instructions
On studio dashboard enter to a course
Click to edit or create a unit
Add a new component video type
On the video modal scroll down to fallback video section and verify the text.