-
Notifications
You must be signed in to change notification settings - Fork 119
feat: added process to sync discussions topic on page load #1942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AhtishamShahid
wants to merge
6
commits into
openedx:master
Choose a base branch
from
AhtishamShahid:ahtisham/INF-1846
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe6639c
to
7cce863
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1942 +/- ##
==========================================
+ Coverage 93.82% 93.94% +0.12%
==========================================
Files 1150 1154 +4
Lines 24054 24087 +33
Branches 5193 5198 +5
==========================================
+ Hits 22568 22628 +60
+ Misses 1409 1391 -18
+ Partials 77 68 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f8d77a5
to
83c001b
Compare
feat: added process to sync discussions topic on page load fix: updated failing unit tests feat: added course creation date in index api feat: added course creation date in index api fix: updated unit tests
83c001b
to
93caa0e
Compare
awais-ansari
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates a new API that properly synchronizes discussion topics when creating course re-runs. It addresses an issue where discussion topic data wasn't being correctly synced to new courses, particularly affecting larger courses.
Problem
When creating re-runs of larger courses, discussion topic data was inconsistently synchronized to the new course, leading to data inconsistencies in the CSM UI.
Solution
Implemented an API call that ensures discussion topic data is properly synchronized between the original course and its re-run. This guarantees that all discussion data remains up-to-date and consistent in the CMS UI.