Skip to content

Conversation

@rpenido
Copy link
Contributor

@rpenido rpenido commented Apr 11, 2025

Description

This PR allows adding existing components to units

image

Additional Information

Testing instructions

  • Go to the library home of a library.
  • Create a Unit.
  • Open the Unit page of the new unit.
  • Click on Add content button.
  • Click on "Existing Library Content"
  • Select some components and click on "Add to Unit"
  • Verify that the blocks are added to the unit

Note: Before merging #1797 you may see another Units on the component picker


Private ref: FAL-4059

@openedx-webhooks
Copy link

openedx-webhooks commented Apr 11, 2025

Thanks for the pull request, @rpenido!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 11, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 11, 2025
@rpenido rpenido force-pushed the rpenido/fal-4059/add-existing-component-to-unit branch 2 times, most recently from aa29d24 to 9b99158 Compare April 12, 2025 03:16
@codecov
Copy link

codecov bot commented Apr 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.58%. Comparing base (aa8a5bf) to head (dfa4dca).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1811   +/-   ##
=======================================
  Coverage   93.57%   93.58%           
=======================================
  Files        1139     1139           
  Lines       23310    23324   +14     
  Branches     5038     5027   -11     
=======================================
+ Hits        21813    21828   +15     
- Misses       1421     1428    +7     
+ Partials       76       68    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rpenido rpenido force-pushed the rpenido/fal-4059/add-existing-component-to-unit branch from 9b99158 to 632adbb Compare April 12, 2025 04:21
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Apr 14, 2025
Copy link
Contributor

@DanielVZ96 DanielVZ96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the same unit appearing in the selection modal, i saw no other issues. lgtm! let me know when that other PR is merged

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 14, 2025
@pomegranited
Copy link
Contributor

@rpenido would you be able to address Sam's comment on @ChrisChV 's issue here?
#1619 (comment)

@rpenido rpenido force-pushed the rpenido/fal-4059/add-existing-component-to-unit branch 3 times, most recently from 58d35ed to 99e8946 Compare April 15, 2025 19:27
@rpenido rpenido force-pushed the rpenido/fal-4059/add-existing-component-to-unit branch 2 times, most recently from 71a08cb to 13cadf6 Compare April 15, 2025 19:53
@rpenido rpenido force-pushed the rpenido/fal-4059/add-existing-component-to-unit branch from 13cadf6 to dfa4dca Compare April 15, 2025 20:24
@rpenido rpenido marked this pull request as ready for review April 15, 2025 20:33
@rpenido
Copy link
Contributor Author

rpenido commented Apr 15, 2025

@rpenido would you be able to address Sam's comment on @ChrisChV 's issue here? #1619 (comment)

Sure @pomegranited! Fixed here: 504cd32

I also fixed a bug that the "Open" button on the Unit Sidebar didn't work inside a collection.

@ChrisChV ChrisChV merged commit d9dcdfe into openedx:master Apr 15, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Apr 15, 2025
@ChrisChV ChrisChV deleted the rpenido/fal-4059/add-existing-component-to-unit branch April 15, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants