-
Notifications
You must be signed in to change notification settings - Fork 172
feat: add existing components to unit [FC-0083] #1811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add existing components to unit [FC-0083] #1811
Conversation
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
aa29d24 to
9b99158
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1811 +/- ##
=======================================
Coverage 93.57% 93.58%
=======================================
Files 1139 1139
Lines 23310 23324 +14
Branches 5038 5027 -11
=======================================
+ Hits 21813 21828 +15
- Misses 1421 1428 +7
+ Partials 76 68 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9b99158 to
632adbb
Compare
DanielVZ96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides the same unit appearing in the selection modal, i saw no other issues. lgtm! let me know when that other PR is merged
|
@rpenido would you be able to address Sam's comment on @ChrisChV 's issue here? |
58d35ed to
99e8946
Compare
71a08cb to
13cadf6
Compare
13cadf6 to
dfa4dca
Compare
Sure @pomegranited! Fixed here: 504cd32 I also fixed a bug that the "Open" button on the Unit Sidebar didn't work inside a collection. |
Description
This PR allows adding existing components to units
Additional Information
Testing instructions
Note: Before merging #1797 you may see another Units on the component picker
Private ref: FAL-4059