-
Notifications
You must be signed in to change notification settings - Fork 123
fix: Adjust course import dropzone height to make course import status visible #1664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adjust course import dropzone height to make course import status visible #1664
Conversation
Thanks for the pull request, @efortish! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hello @mariajgrimaldi, could you help me with the review of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd call this a fix:
rather than a feat:
, but otherwise, looks great! Thank you!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1664 +/- ##
==========================================
+ Coverage 93.30% 93.33% +0.02%
==========================================
Files 1101 1107 +6
Lines 21856 22002 +146
Branches 4741 4672 -69
==========================================
+ Hits 20393 20535 +142
- Misses 1392 1402 +10
+ Partials 71 65 -6 ☔ View full report in Codecov by Sentry. |
dda8687
to
9b83975
Compare
Hello @kdmccormick, I hope you are doing well. |
Perfect. I'll merge as soon as tests pass. Thanks for your contribution @efortish ! |
Adjust course import dropzone height to make course import status visible
Description
This PR addresses the issue where the
Dropzone
component was too large, obstructing the view of the course import status. The height of theDropzone
has been adjusted to 200 pixels to ensure that users can see more information about the course import status while importing a course.Changes Made
Dropzone
component to 200 pixels.Achievements
Dropzone
ensures that important information is not obstructed.Testing
Related Issues
Additional Notes
Dropzone
does not affect other functionalities or components on the page.