Skip to content

fix: Adjust course import dropzone height to make course import status visible #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

efortish
Copy link
Contributor

Adjust course import dropzone height to make course import status visible

Description

This PR addresses the issue where the Dropzone component was too large, obstructing the view of the course import status. The height of the Dropzone has been adjusted to 200 pixels to ensure that users can see more information about the course import status while importing a course.

Changes Made

  • Adjusted the height of the Dropzone component to 200 pixels.

Achievements

  • Improved Visibility: Users can now see more information about the course import status while importing a course without scrolling.
  • Enhanced User Experience: The reduced height of the Dropzone ensures that important information is not obstructed.

Testing

  • Our UI/UX team member ensured that the course import status is more visible during the import process.

image

Related Issues

  • Issue #1387: Course Import - Upload widget hides the import success message

Additional Notes

  • Ensure that the reduced height of the Dropzone does not affect other functionalities or components on the page.

@openedx-webhooks
Copy link

Thanks for the pull request, @efortish!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 18, 2025
@efortish efortish closed this Feb 18, 2025
@efortish efortish reopened this Feb 18, 2025
@efortish
Copy link
Contributor Author

Hello @mariajgrimaldi, could you help me with the review of this PR?

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call this a fix: rather than a feat:, but otherwise, looks great! Thank you!

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.33%. Comparing base (59243b0) to head (9b83975).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1664      +/-   ##
==========================================
+ Coverage   93.30%   93.33%   +0.02%     
==========================================
  Files        1101     1107       +6     
  Lines       21856    22002     +146     
  Branches     4741     4672      -69     
==========================================
+ Hits        20393    20535     +142     
- Misses       1392     1402      +10     
+ Partials       71       65       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efortish efortish changed the title feat: Adjust course import dropzone height to make course import status visible fix: Adjust course import dropzone height to make course import status visible Feb 18, 2025
@efortish efortish force-pushed the CourseImportDropZoneUpdate branch from dda8687 to 9b83975 Compare February 19, 2025 14:52
@efortish
Copy link
Contributor Author

Hello @kdmccormick, I hope you are doing well.
I already made the commit title change and the PR too, can you please help me checking if everything is ok to merge the changes, let me know if there is something else that I can do in this PR. Thank you so much

@kdmccormick kdmccormick enabled auto-merge (squash) February 21, 2025 16:39
@kdmccormick
Copy link
Member

Perfect. I'll merge as soon as tests pass. Thanks for your contribution @efortish !

@kdmccormick kdmccormick merged commit 3e235d3 into openedx:master Feb 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants