-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Link-on-Paste for V2 Library Components #1202
base: master
Are you sure you want to change the base?
Conversation
47af534
to
4aafe29
Compare
Sandbox deployment successful 🚀 |
Sandbox deployment successful 🚀 |
4aafe29
to
2a3513d
Compare
Sandbox deployment failed 💥 |
2a3513d
to
315d4ea
Compare
Sandbox deployment failed 💥 |
Sandbox deployment failed 💥 |
Sandbox deployment failed 💥 |
315d4ea
to
be2a60c
Compare
Sandbox deployment failed 💥 |
be2a60c
to
29ed1a7
Compare
Sandbox deployment successful 🚀 |
4324413
to
06c5f00
Compare
Sandbox deployment failed 💥 |
06c5f00
to
ce520e4
Compare
Sandbox deployment failed 💥 |
Sandbox deployment failed 💥 |
Sandbox deployment failed 💥 |
Sandbox deployment failed 💥 |
ce520e4
to
2247b38
Compare
Sandbox deployment failed 💥 |
Sandbox deployment successful 🚀 |
2247b38
to
1540a3d
Compare
Sandbox deployment failed 💥 |
Sandbox deployment failed 💥 |
Sandbox deployment failed 💥 |
@@ -30,10 +30,10 @@ const PasteComponent = ({ | |||
</Popover> | |||
</div> | |||
); | |||
|
|||
const textt = (clipboardData.sourceContextTitle || "").startsWith("lib:") ? "Link library component from clipboard" : text; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use isLibraryKey
const textt = (clipboardData.sourceContextTitle || "").startsWith("lib:") ? "Link library component from clipboard" : text; | |
const textt = isLibraryKey(clipboardData.sourceContextTitle) ? "Link library component from clipboard" /* TODO: needs i18n */ : text; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
@bradenmacdonald since you're taking a look -- I'm going to take out the "Update from library" parts of this before putting it up for final review. That was just for testing. |
@kdmccormick Ah, fair enough. |
1540a3d
to
53fef2c
Compare
Sandbox deployment failed 💥 |
Settings
Tutor requirements
Uses: openedx/edx-platform#34925