Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FC-0059] refactor: Change lib v2 code to TS #1124

Closed

Conversation

yusuf-musleh
Copy link
Contributor

Description

This PR swaps back the new changes related to v2/legacy Libraries from js -> ts and jsx -> tsx. They were initially removed from #1050 as it was merged before #1052 was completed.

It's based off #1117 as further changes were made there.

Supporting information

Testing instructions

Make sure linting/typing checking passes and confirm that its is still functional. You can follow the testing steps in #1050


Private-ref: FAL-3751

@openedx-webhooks
Copy link

Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 23, 2024
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/use-ts-for-lib-v2 branch from 5c6ac20 to 9694943 Compare June 23, 2024 15:39
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/use-ts-for-lib-v2 branch 3 times, most recently from 86f9371 to f0ea105 Compare June 24, 2024 13:36
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 98.48485% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.72%. Comparing base (292663a) to head (05eda0a).
Report is 680 commits behind head on master.

Files with missing lines Patch % Lines
...on/libraries-v2-tab/libraries-v2-filters/index.jsx 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
+ Coverage   92.67%   92.72%   +0.04%     
==========================================
  Files         696      698       +2     
  Lines       12392    12434      +42     
  Branches     2714     2711       -3     
==========================================
+ Hits        11484    11529      +45     
+ Misses        876      874       -2     
+ Partials       32       31       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bradenmacdonald
Copy link
Contributor

Note there is a bug that linting for .ts[x] files is not happening properly; I'm fixing it in #1129 but please manually make this change and run npm run lint yourself to make sure this PR is good too.

@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/use-ts-for-lib-v2 branch from f0ea105 to 5d4c369 Compare June 25, 2024 15:41
@yusuf-musleh yusuf-musleh changed the title refactor: Change lib v2 code to TS [FC-0059] refactor: Change lib v2 code to TS Jun 26, 2024
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/use-ts-for-lib-v2 branch from a72713e to 05eda0a Compare July 5, 2024 14:31
@yusuf-musleh
Copy link
Contributor Author

Closing this PR as the changes are small enough and related to #1117 so I merged the changes into that.

@openedx-webhooks
Copy link

@yusuf-musleh Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Libraries Tab of Studio Home (v2)
4 participants