Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FC-0001: Replace usages enterprise_catalog Enterprise API V1 #801

Merged

Conversation

ruzniaievdm
Copy link
Contributor

@ruzniaievdm ruzniaievdm commented Jun 13, 2022

(2 of 5) for closes openedx/public-engineering#61

Latest: openedx/edx-enterprise#1582

Description:

Replace this usage with corresponding to the enterprise-catalog service

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Jun 13, 2022
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 13, 2022

Thanks for the pull request, @ruzniaievdm! I've created OSPR-6795 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #801 (f469e98) into master (0b81464) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #801   +/-   ##
=======================================
  Coverage   82.40%   82.40%           
=======================================
  Files         331      331           
  Lines        7966     7966           
  Branches     1797     1797           
=======================================
  Hits         6564     6564           
  Misses       1378     1378           
  Partials       24       24           
Impacted Files Coverage Δ
src/components/ReportingConfig/index.jsx 45.28% <ø> (ø)
src/data/services/LmsApiService.js 33.77% <ø> (-1.30%) ⬇️
src/data/services/EnterpriseCatalogApiService.js 45.45% <100.00%> (+20.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b81464...f469e98. Read the comment docs.

@feanil feanil self-assigned this Jul 6, 2022
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me, @adamstankiewicz can you take a second look and help get this deployed?

@feanil
Copy link
Contributor

feanil commented Jul 28, 2022

@natabene this is ready for 2U review.

@adamstankiewicz adamstankiewicz merged commit 9966ef5 into openedx:master Sep 19, 2022
@openedx-webhooks
Copy link

@ruzniaievdm 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

[DEPR]: Remove Enterprise Catalog API V1 from edx-enterprise
4 participants