Skip to content

Conversation

diana-villalvazo-wgu
Copy link
Contributor

Description

As part of the project for improvements as follow up of react-unit-test-utils, we are going to replace all usages of the deprecated injectIntl HOC with the useIntl() hook from @edx/frontend-platform/i18n. It is a very straight-forward change, in order to accomplish this we did the following changes:

  • In components we have to remove the old injectIntl, remove intl as a prop and use the hook instead. In some components in order to use useIntl() hook we had to refactor some class components into functional components.

Files to refactor:

  • src/components/subscriptions/licenses/LicenseAllocationHeader.jsx
  • src/components/NewFeatureAlertBrowseAndRequest/index.jsx
  • src/components/ReportingConfig/index.jsx
  • src/components/ReportingConfig/ReportingConfigForm.jsx
  • src/components/RequestCodesPage/RequestCodesForm.jsx

Support Information

Closes #1593

@openedx-webhooks
Copy link

Thanks for the pull request, @diana-villalvazo-wgu!

This repository is currently maintained by @openedx/2u-enterprise.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 12, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Aug 12, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Aug 12, 2025
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 78.94737% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.90%. Comparing base (8c749e4) to head (05a1bd9).

Files with missing lines Patch % Lines
...components/ReportingConfig/ReportingConfigForm.jsx 79.31% 18 Missing ⚠️
src/components/ReportingConfig/index.jsx 73.84% 16 Missing and 1 partial ⚠️
...c/components/RequestCodesPage/RequestCodesForm.jsx 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1644   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files         797      797           
  Lines       18152    18164   +12     
  Branches     3803     3712   -91     
=======================================
+ Hits        15775    15786   +11     
- Misses       2299     2311   +12     
+ Partials       78       67   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Needs Triage to Ready for Review in Contributions Aug 12, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu requested review from a team August 12, 2025 21:45
@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Aug 26, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 1593/injectIntl-3of4 branch 2 times, most recently from f9cd45c to 2c16dc0 Compare September 1, 2025 16:59
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 1593/injectIntl-3of4 branch 2 times, most recently from c57ec96 to ca488d6 Compare September 8, 2025 19:38
@mphilbrick211
Copy link

Hi @openedx/2u-enterprise! Would someone be able to review this for us? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

Replace of injectIntl with useIntl() 3/4
4 participants