-
Notifications
You must be signed in to change notification settings - Fork 35
Replace of injectIntl with useIntl() 3/4 #1644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Replace of injectIntl with useIntl() 3/4 #1644
Conversation
Thanks for the pull request, @diana-villalvazo-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1644 +/- ##
=======================================
Coverage 86.90% 86.90%
=======================================
Files 797 797
Lines 18152 18164 +12
Branches 3803 3712 -91
=======================================
+ Hits 15775 15786 +11
- Misses 2299 2311 +12
+ Partials 78 67 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5ae06e9
to
a90b957
Compare
f9cd45c
to
2c16dc0
Compare
c57ec96
to
ca488d6
Compare
Hi @openedx/2u-enterprise! Would someone be able to review this for us? Thanks! |
ca488d6
to
05a1bd9
Compare
Description
As part of the project for improvements as follow up of react-unit-test-utils, we are going to replace all usages of the deprecated
injectIntl
HOC with theuseIntl()
hook from @edx/frontend-platform/i18n. It is a very straight-forward change, in order to accomplish this we did the following changes:injectIntl
, remove intl as a prop and use the hook instead. In some components in order to useuseIntl()
hook we had to refactor some class components into functional components.Files to refactor:
Support Information
Closes #1593