Skip to content

Conversation

brobro10000
Copy link
Member

@brobro10000 brobro10000 commented May 22, 2025

For all changes

Benchmarking results and related documentation proposing an optimized implementation of the calculateMovingAverage function for the analytics page.

Docs: https://github.com/openedx/frontend-app-admin-portal/blob/28e872a03a04d8f7ed3922dceb5d7ad854be9bf5/README-benchmark.md

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.20%. Comparing base (f84f960) to head (28e872a).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/components/AdvanceAnalyticsV2/data/utils.js 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
+ Coverage   87.08%   87.20%   +0.11%     
==========================================
  Files         694      703       +9     
  Lines       15891    16054     +163     
  Branches     3368     3386      +18     
==========================================
+ Hits        13839    14000     +161     
- Misses       1979     1982       +3     
+ Partials       73       72       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant