Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to the new version of brand-openedx in the new scope. #1064

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Oct 19, 2023

Part of openedx/axim-engineering#23

This updates the brand alias to point to the package at the openedx
scope. This does not impact imports because this package is used via an
alias.

@feanil feanil force-pushed the feanil/update_brand_dependency branch from 7df6a60 to 6fe154b Compare October 19, 2023 19:45
@feanil feanil requested review from adamstankiewicz and a team October 19, 2023 19:46
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (080692c) 83.60% compared to head (6fe154b) 83.60%.

❗ Current head 6fe154b differs from pull request most recent head 9d1ebc3. Consider uploading reports for the commit 9d1ebc3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
- Coverage   83.60%   83.60%   -0.01%     
==========================================
  Files         443      443              
  Lines        9444     9442       -2     
  Branches     1968     1968              
==========================================
- Hits         7896     7894       -2     
  Misses       1505     1505              
  Partials       43       43              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Part of openedx/axim-engineering#23

This updates the brand alias to point to the package at the `openedx`
scope.  This does not impact imports because this package is used via an
alias.
@feanil feanil force-pushed the feanil/update_brand_dependency branch from 6fe154b to 9d1ebc3 Compare October 23, 2023 14:23
@brian-smith-tcril brian-smith-tcril merged commit 8b12828 into master Oct 23, 2023
4 checks passed
@brian-smith-tcril brian-smith-tcril deleted the feanil/update_brand_dependency branch October 23, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants