Skip to content

Conversation

@taimoor-ahmed-1
Copy link
Contributor

This commit introduces query optimizations to reduce database queries and improve response times:

  • Fixed N+1 queries in threads_presentor, get_paginated_user_stats, and other methods using select_related/prefetch_related
  • Optimized get_read_states to prefetch data in bulk instead of individual queries
  • Optimized get_abuse_flagged_count and get_endorsed with bulk aggregations
  • Removed duplicate annotations in handle_threads_query
  • Added query optimizations across prepare_thread, validate_thread_and_user, and other methods

Performance impact: Reduced queries from O(n) to O(1)/O(k), eliminated N+1 patterns, improved bulk operations. All changes maintain backward compatibility.

This commit introduces query optimizations to reduce database queries and
improve response times:

- Fixed N+1 queries in threads_presentor, get_paginated_user_stats, and
  other methods using select_related/prefetch_related
- Optimized get_read_states to prefetch data in bulk instead of individual
  queries
- Optimized get_abuse_flagged_count and get_endorsed with bulk aggregations
- Removed duplicate annotations in handle_threads_query
- Added query optimizations across prepare_thread, validate_thread_and_user,
  and other methods

Performance impact: Reduced queries from O(n) to O(1)/O(k), eliminated N+1
patterns, improved bulk operations. All changes maintain backward compatibility.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 18, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 18, 2025

Thanks for the pull request, @taimoor-ahmed-1!

This repository is currently maintained by @openedx/wg-maintainers-forums.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@taimoor-ahmed-1
Copy link
Contributor Author

@ormsbee this is the initial work to optimize the mysql backend in forum. I am working on providing improvement stats as POC for this work.

@taimoor-ahmed-1 taimoor-ahmed-1 marked this pull request as draft November 18, 2025 19:33
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

3 participants