Skip to content

Conversation

@taimoor-ahmed-1
Copy link
Contributor

This PR adds get_user_comments api that retrieves all of the user comments as it was also supported in the cs_comments_service backend.

@taimoor-ahmed-1 taimoor-ahmed-1 self-assigned this Oct 20, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @taimoor-ahmed-1!

This repository is currently maintained by @openedx/wg-maintainers-forums.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 20, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Oct 20, 2025
This PR adds get_user_comments api that retrieves all of the user comments as it was also supported in the cs_comments_service backend.
@taimoor-ahmed-1 taimoor-ahmed-1 force-pushed the feat/add_get_user_comments_api branch from 17ff7aa to 75deaab Compare October 20, 2025 07:13
Copy link
Contributor

@Faraz32123 Faraz32123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know it's usage in edx-platform and plan to make any PR in edx-platform as well?
Or we are just adding an API to replicate what was in cs_comment_service?

@taimoor-ahmed-1
Copy link
Contributor Author

Do we know it's usage in edx-platform and plan to make any PR in edx-platform as well? Or we are just adding an API to replicate what was in cs_comment_service?

@Faraz32123 I have added the relevant api call in edx-platform

@taimoor-ahmed-1 taimoor-ahmed-1 merged commit 4254215 into master Oct 20, 2025
14 checks passed
@taimoor-ahmed-1 taimoor-ahmed-1 deleted the feat/add_get_user_comments_api branch October 20, 2025 09:17
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Oct 20, 2025
@Faraz32123
Copy link
Contributor

Faraz32123 commented Oct 20, 2025

@Faraz32123 I have added the relevant api call in edx-platform

Best! Can we also attach that PR's link here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants