Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin the pip-tools version to 6.6.2 #561

Conversation

tecoholic
Copy link

@tecoholic tecoholic commented Jan 23, 2023

Description

The pip-tools version currently used breaks with the error ImportError: cannot import name 'BAR_TYPES' from 'pip._internal.cli.progress_bars' during the deployment. This is fixed in the version 6.6.2 as reported in jazzband/pip-tools#1617.

So, this commit pins the pip-tools version to 6.6.2 for the open-release/nutmeg.master

Ticket Link

NA

Similar fixes

Post-review

  • Squash commits into discrete sets of changes
  • Ensure that once the changes have been deployed to stage, prod is manually deployed

The pip-tools version currently used breaks with the error
"ImportError: cannot import name 'BAR_TYPES' from 'pip._internal.cli.progress_bars'"
during the deployment. This is fixed in the version 6.6.2 as reported
in jazzband/pip-tools#1617.

So, this commit pins the pip-tools version to 6.6.2
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 23, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @tecoholic! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 27, 2023
@mphilbrick211
Copy link

Hi @tecoholic! Thanks for this contribution - I'm looking into getting tests run on this PR for you.

@mphilbrick211
Copy link

@e0d would you mind authorizing tests on this? Thanks!

@e0d
Copy link

e0d commented Feb 7, 2023

Done

@mphilbrick211
Copy link

Hi @tecoholic - you should be all set to re-run the failing tests. Thanks!

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 7, 2023
@tecoholic
Copy link
Author

@mphilbrick211 The CI seems broken and doesn't seem to be connected to the changes introduced in the PR. How do we handle this? Should we ask someone with maintainer rights to check on this?

@mphilbrick211
Copy link

@macdiesel would you mind taking a look at the author's question above?

@mphilbrick211
Copy link

Hi @macdiesel - friendly follow-up on this :)

@mphilbrick211
Copy link

Hi @macdiesel - just checking in on this :)

@mphilbrick211
Copy link

Hi @macdiesel - friendly ping on this!

@johnnagro johnnagro merged commit 27b564c into openedx:open-release/nutmeg.master Apr 25, 2023
@openedx-webhooks
Copy link

@tecoholic 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@Agrendalath Agrendalath deleted the tecoholic/fix-pip-tools-version branch September 13, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants