-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: standardize make extract_translations #1124
feat: standardize make extract_translations #1124
Conversation
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
This PR needs openedx/edx-proctoring#1124 before it's merged. Refs: FC-0012 OEP-58
ready for review @OmarIthawi @brian-smith-tcril |
The failing test is a codcov issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
What do you think the cause of the following error?
[2023-04-27T14:33:42.322Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
@OmarIthawi I just re-ran the failing test and it passed this time. Codecov seems to be less than perfectly reliable. |
96650cb
to
407020f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@mphilbrick211 this one is good to go! It's marked as "No extra review required" on the spreadsheet, so it should just be a matter of getting a CC with perms on the repo to approve/merge! |
Hi @chennighan2u and @openedx/masters-devs-cosmonauts! Could someone please merge this for us? Thanks! |
Refs: FC-0012 OEP-58
407020f
to
78862f8
Compare
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR needs openedx/edx-proctoring#1124 before it's merged. Refs: FC-0012 OEP-58
feat: standardize make extract_translations
Refs: FC-0012 OEP-58
This PR prepares the repository to comply with openedx-translations by doing the following:
edx_proctoring/locale
toedx_proctoring/conf/locale
edx_proctoring/locale
toedx_proctoring/conf/locale
make extract_translations
to usedjango-admin
instead ofmanage.py
References
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes
For XBlocks:
conf/locale
. Therefore, we are creating a link fromconf/locale
totranslations
so Atlas can find the path without disrupting the current way of having translations locally within the XBlocks