-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: Resolves failing tests when CERTIFICATE_LINKEDIN setting is configured #37437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @haftamuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
5719fef
to
9d75af6
Compare
…gured at common.py openedx#37428 In order to be able to share course certificate to LinkedIn, configure SOCIAL_SHARING_SETTINGS with a value True for CERTIFICATE_LINKEDIN entry. The setting is not available by default, but when used there were failing tests and this change ensures all tests pass. Fixes: openedx#37428 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit here, also, could you resolve the conflicts?
'do not have a current verified identity with {platform_name}' | ||
.format(platform_name=settings.PLATFORM_NAME)) | ||
|
||
def test_post_to_linkedin_visibility(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] look at how other tests in this file use ddt.data
. For a simple case like this, that can be a cleaner way to test the condition. For example, you can use
@ddt.data(
(True, True),
(False, False),
)
@ddt.unpack
def test_post_to_linkedin_visibility(self, certificate_linkedin_enabled, linkedin_button_visible):
and then you don't need to test both configurations separately; the test runner will verify both configurations for you.
In order to be able to share course certificate to LinkedIn, configure SOCIAL_SHARING_SETTINGS with a value True for CERTIFICATE_LINKEDIN entry. The setting is not available by default, but when used there were failing tests and this change ensures all tests pass.
Fixes: #37428 (comment)
Testing instructions
Change configuration value of CERTIFICATE_LINKEDIN to True at /lms/envs/common.py and cms/envs/common.py
run
python -Wd -m pytest -p no:randomly --ds=lms.envs.test common/djangoapps/student/tests/
See all tests should pass
Change configuration value of CERTIFICATE_LINKEDIN to False at /lms/envs/common.py and cms/envs/common.py
run
python -Wd -m pytest -p no:randomly --ds=lms.envs.test common/djangoapps/student/tests/
See all tests should pass