feat: removing get_storage_class from COURSE_METADATA_EXPORT_STORAGE

cms/djangoapps/export_course_metadata/storage.py

@@ -4,7 +4,7 @@
 
 
 from django.conf import settings
-from django.core.files.storage import get_storage_class
+from common.djangoapps.util.storage import resolve_storage_backend
 from storages.backends.s3boto3 import S3Boto3Storage
 
 
@@ -17,4 +17,4 @@ def __init__(self):
         bucket = settings.COURSE_METADATA_EXPORT_BUCKET
         super().__init__(bucket_name=bucket, custom_domain=None, querystring_auth=True)
 
-course_metadata_export_storage = get_storage_class(settings.COURSE_METADATA_EXPORT_STORAGE)()
+course_metadata_export_storage = resolve_storage_backend("COURSE_METADATA_EXPORT_STORAGE")

cms/djangoapps/export_course_metadata/test_signals.py

@@ -3,11 +3,15 @@
 """
 
 from unittest.mock import patch
+from django.test.utils import override_settings
+from django.conf import settings
 
 from edx_toggles.toggles.testutils import override_waffle_flag
 from xmodule.modulestore.django import SignalHandler
 from xmodule.modulestore.tests.django_utils import SharedModuleStoreTestCase
 from xmodule.modulestore.tests.factories import CourseFactory, BlockFactory
+from common.djangoapps.util.storage import resolve_storage_backend
+from storages.backends.s3boto3 import S3Boto3Storage
 
 from .signals import export_course_metadata
 from .toggles import EXPORT_COURSE_METADATA_FLAG
@@ -53,3 +57,66 @@ def test_happy_path(self, patched_content, patched_storage):
         patched_storage.save.assert_called_once_with(
             f'course_metadata_export/{self.course_key}.json', patched_content.return_value
         )
+
+    @override_settings(
+        COURSE_METADATA_EXPORT_STORAGE="cms.djangoapps.export_course_metadata.storage.CourseMetadataExportS3Storage",
+        DEFAULT_FILE_STORAGE="django.core.files.storage.FileSystemStorage"
+    )
+    def test_resolve_default_storage(self):
+        """ Ensure the default storage is invoked, even if course export storage is configured """
+        storage = resolve_storage_backend("default")
+        self.assertEqual(storage.__class__.__name__, "FileSystemStorage")
+
+    @override_settings(
+        COURSE_METADATA_EXPORT_STORAGE="cms.djangoapps.export_course_metadata.storage.CourseMetadataExportS3Storage",
+        DEFAULT_FILE_STORAGE="django.core.files.storage.FileSystemStorage",
+        COURSE_METADATA_EXPORT_BUCKET="bucket_name_test"
+    )
+    def test_resolve_happy_path_storage(self):
+        """ Make sure that the correct course export storage is being used """
+        storage = resolve_storage_backend("COURSE_METADATA_EXPORT_STORAGE")
+        self.assertEqual(storage.__class__.__name__, "CourseMetadataExportS3Storage")
+        self.assertEqual(storage.bucket_name, "bucket_name_test")
+
+    @override_settings()
+    def test_resolve_storage_with_no_config(self):
+        """ If no storage setup is defined, we get FileSystemStorage by default """
+        del settings.DEFAULT_FILE_STORAGE
+        del settings.COURSE_METADATA_EXPORT_STORAGE
+        del settings.COURSE_METADATA_EXPORT_BUCKET
+        storage = resolve_storage_backend("COURSE_METADATA_EXPORT_STORAGE")
+        self.assertEqual(storage.__class__.__name__, "FileSystemStorage")
+
+    @override_settings(
+        COURSE_METADATA_EXPORT_STORAGE=None,
+        COURSE_METADATA_EXPORT_BUCKET="bucket_name_test",
+        STORAGES={
+            'COURSE_METADATA_EXPORT_STORAGE': {
+                'BACKEND': 'cms.djangoapps.export_course_metadata.storage.CourseMetadataExportS3Storage',
+                'OPTIONS': {}
+            }
+        }
+    )
+    def test_resolve_storage_using_django5_settings(self):
+        """ Simulating a Django 4 environment using Django 5 Storages configuration """
+        storage = resolve_storage_backend("COURSE_METADATA_EXPORT_STORAGE")
+        self.assertEqual(storage.__class__.__name__, "CourseMetadataExportS3Storage")
+        self.assertEqual(storage.bucket_name, "bucket_name_test")
+
+    @override_settings(
+        STORAGES={
+            'COURSE_METADATA_EXPORT_STORAGE': {
+                'BACKEND': 'storages.backends.s3boto3.S3Boto3Storage',
+                'OPTIONS': {
+                    'bucket_name': 'bucket_name_test'
+                }
+            }
+        }
+    )
+    def test_resolve_storage_using_django5_settings_with_options(self):
+        """ Ensure we call the storage class with the correct parameters and Django 5 setup """
+        del settings.COURSE_METADATA_EXPORT_STORAGE
+        del settings.COURSE_METADATA_EXPORT_BUCKET
+        storage = resolve_storage_backend("COURSE_METADATA_EXPORT_STORAGE")
+        self.assertEqual(storage.__class__.__name__, S3Boto3Storage.__name__)
+        self.assertEqual(storage.bucket_name, "bucket_name_test")

common/djangoapps/util/storage.py

@@ -0,0 +1,53 @@
+""" Utility functions related to django storages """
+
+from django.conf import settings
+from django.core.files.storage import default_storage, storages
+from django.utils.module_loading import import_string
+
+
+def resolve_storage_backend(storage_key, options=None):
+    """
+    Configures and returns a Django `Storage` instance, compatible with both Django 4 and Django 5.
+
+    Main goal:
+        Deprecate the use of `django.core.files.storage.get_storage_class`.
+    How:
+        Replace `get_storage_class` with direct configuration logic,
+        ensuring backward compatibility with both Django 4 and Django 5 storage settings.
+    Returns:
+        An instance of the configured storage backend.
+    Raises:
+        ImportError: If the specified storage class cannot be imported.
+    """
+
+    storage_path = getattr(settings, storage_key, None)
+    storages_config = getattr(settings, 'STORAGES', {})
+
+    if options is None:
+        options = {}
+
+    if storage_key == "default":
+        # Use case 1: Default storage
+        # Works consistently across Django 4.2 and 5.x
+        # In Django 4.2 and above, `default_storage` uses
+        # either `DEFAULT_FILE_STORAGE` or `STORAGES['default']`.
+        return default_storage
+
+    if storage_key in storages_config:
+        # Use case 2: STORAGES is defined
+        # If STORAGES is present, we retrieve it through the storages API
+        # settings.py must define STORAGES like:
+        # STORAGES = {
+        #     "default": {"BACKEND": "...", "OPTIONS": {...}},
+        #     "custom": {"BACKEND": "...", "OPTIONS": {...}},
+        # }
+        # See: https://docs.djangoproject.com/en/5.2/ref/settings/#std-setting-STORAGES
+        return storages[storage_key]
+
+    if not storage_path:
+        # If no storage settings are defined anywhere, use the default storage
+        return default_storage
+
+    # Fallback to import the storage_path manually
+    StorageClass = import_string(storage_path)
+    return StorageClass(**options)