-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-select for Randomized Problem Banks [FC-0062] #35705
Multi-select for Randomized Problem Banks [FC-0062] #35705
Conversation
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
6234fa2
to
07a1c8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works great, awesome work @bradenmacdonald !
- I tested this on my tutor dev env using the PR test instructions
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
⚠️ There's a a11y bug in the component picker (unrelated to this PR) -- I'm unable to select a library using just my keyboard. - Includes documentation
- User-facing strings are extracted for translation
@ormsbee @kdmccormick (CC @pomegranited) Can you help get this one merged Wednesday AM in addition to #35679 ? I'll try to get online a bit earlier than usual but am not going to have much time myself before the cut, and this is very high priority. |
@bradenmacdonald Can do. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Description
This implements basic multi-select for adding components to a problem bank.
multi-select.for.problem.bank.mov
Note: nothing stops you from adding the same blocks multiple times. Blocks you've already added will still appear in the modal.
Supporting information
Depends/builds on #35679 and openedx/frontend-app-authoring#1417
Private ref FAL-3898.
Testing instructions
tutor dev exec lms openedx-assets build --env=dev
"itembank"
to a course's Advanced Module ListDeadline
ASAP - we need this in Sumac.