feat!: upgrading mark_student_can_skip_entrance_exam api with DRF ( 21 ) #35460
+40
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awais786
changed the title
awais786
changed the title
feanil
reviewed
Sep 19, 2024
| @@ -3165,6 +3165,42 @@ def mark_student_can_skip_entrance_exam(request, course_id): | |||
| return JsonResponse(response_payload) | |||
|
|
|||
|
|
|||
| @method_decorator(cache_control(no_cache=True, no_store=True, must_revalidate=True), name='dispatch') | |||
| class MarkStudentCanSkipEntranceExam(APIView): | |||
There was a problem hiding this comment.
@awais786 should there be an old function that is deleted? I don't see the deletion here.
There was a problem hiding this comment.
Yes, i missed that. Thanks for catching.
|
@feanil please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35284
Postman testing
unique_student_identifier=adminexpected result
{ "message": "This student (admin) is already allowed to skip the entrance exam." }end to end testing
usernameinAdjust a learner's entrance exam resultsinput boxLet Learner Skip Entrance Exambutton.