-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade send_email api to drf ( 15th ) #35387
Conversation
381e488
to
e9ecbdb
Compare
) | ||
except ValueError as err: | ||
return HttpResponseBadRequest(repr(err)) | ||
targets = json.loads(request.POST.get("send_to")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not handling validation into serializer because there are multiple input combinations, and moving the validation into the serializer would require refactoring, which could introduce errors.
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Issue
Steps to verify postman
You need to enable this flag
http://local.edly.io:8000/admin/bulk_email/bulkemailflag/add/
permissions =
required course role
=staff
orlimited_staff
Try this URL
form-data as post
Try this from instructor dashboard
Go to this URL