-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrading simple api to drf compatible ( 3rd api ) list_email_content #35111
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
42e4963
feat: upgrading simple api to drf compatible.
awais786 20c19bc
feat: upgrading simple api to drf compatible.
awais786 4781036
feat: upgrading simple api to drf compatible.
awais786 1a2af7e
feat: upgrading simple api to drf compatible.
awais786 c0ea5bd
Merge branch 'master' into list_email_content-drf
awais786 67d45d1
Merge branch 'master' into list_email_content-drf
awais786 5f098ba
chore: Update api.py
awais786 b9e4ff3
Merge branch 'master' into list_email_content-drf
awais786 7e40e3e
Merge branch 'master' into list_email_content-drf
awais786 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's confusing that this is a POST request in the first place given that it is not sending any data in the POST body and not making any modifications. But that change was made in #12719 for reasons that are unclear to us now so we'll leave it as is for now and we can re-visit if/when we want to revamp the instructor APIs further.
This will at-least make these APIs all visible in our openapi spec and make the APIs usable by other token types than just session.
(Not something you need to do anything about, just leaving a not for future investigators.)