Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33589: Updated mako_block.py to use MakoService #35033

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

abdullahQureshee
Copy link

@abdullahQureshee abdullahQureshee commented Jun 25, 2024

Resolves #33589. Total of 12005 warnings will be removed according to the deprecated devstack action logs

The render_template check has been removed from constructor and there is no check explicitly implemented for existence of the 'mako' service. This should work because a check is already in place at xblock. The runtime class hierarchy is as follows: caching_descriptor_system.py -> x_module.py -> runtime.py

@openedx-webhooks
Copy link

openedx-webhooks commented Jun 25, 2024

Thanks for the pull request, @abdullahQureshee!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 25, 2024
@abdullahQureshee abdullahQureshee marked this pull request as draft June 25, 2024 10:51
@mphilbrick211
Copy link

Hi @abdullahQureshee! Thank you for this contribution. When you have a moment, would you please put a description of your changes at the top of the pull request?

Please also let me know if you have any questions regarding submitting a CLA form. Thank you!

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 16, 2024
@e0d
Copy link
Contributor

e0d commented Jul 24, 2024

@abdullahQureshee Should you be listed under the edly/Aribisoft entity CLA?

@abdullahQureshee
Copy link
Author

Hi @abdullahQureshee! Thank you for this contribution. When you have a moment, would you please put a description of your changes at the top of the pull request?

Please also let me know if you have any questions regarding submitting a CLA form. Thank you!

Sure. I'm currently doing some RnD on the issue. Once thats done, I'll create a proper PR. Right now its in Draft. I hope its ok to keep the Draft for a bit longer.

@abdullahQureshee
Copy link
Author

@abdullahQureshee Should you be listed under the edly/Aribisoft entity CLA?

Yes.

@mphilbrick211
Copy link

@abdullahQureshee Should you be listed under the edly/Aribisoft entity CLA?

Yes.

@abdullahQureshee - please have your manager send an email to oscm@axim.org to have you added to the existing CLA. Let me know if you have any questions!

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 24, 2024
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Aug 23, 2024
@farhan farhan requested a review from feanil September 24, 2024 09:32
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me. @abdullahQureshee can you rebase this of the latest master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer assigned PR needs to be (re-)assigned a new reviewer open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
6 participants