Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp: build: compile python requirements with 3.8, not 3.11 #34960

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

kdmccormick
Copy link
Member

@kdmccormick kdmccormick commented Jun 10, 2024

We haven't quite dropped Py3.8 support yet, so we can't use these workflows if
they're compiling with 3.11:

  • upgrade-one-python-dependency (upgrading a single, targeted dep)
  • compile-python-requirements (recompiling all deps without upgrading)

So, we "downgrade" those workflows to use 3.8, for now. We should revert this
commit when we drop 3.8 support.

Note: The upgrade-python-requirements.yml workflow is still using 3.8, so this
commit will update the other workflows to match that one.

We haven't quite dropped 3.8 support yet, so we can't use these
workflows if they're compiling with 3.11

Revert this commit when we drop 3.8 support.

WIP: how do we tell the upgrade requirements workflow to use 3.8?
@kdmccormick kdmccormick requested a review from feanil June 10, 2024 15:47
@kdmccormick kdmccormick marked this pull request as ready for review June 10, 2024 15:48
@kdmccormick kdmccormick merged commit a3bafb2 into master Jun 10, 2024
35 of 48 checks passed
@kdmccormick kdmccormick deleted the kdmccormick/upgrade-with-38 branch June 10, 2024 19:50
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@kdmccormick
Copy link
Member Author

When we're ready, this temp change will be reverted by: #34960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants