feanil/test on 3.11 #34374
Merged
feanil/test on 3.11 #34374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feanil
force-pushed
the
feanil/test_on_3.11
branch
2 times, most recently
from
37b5fb9
to
ab4bd00
Compare
feanil
force-pushed
the
feanil/test_on_3.11
branch
2 times, most recently
from
96d8d45
to
ec86f91
Compare
feanil
force-pushed
the
feanil/test_on_3.11
branch
2 times, most recently
from
d915d8d
to
f433751
Compare
4 tasks
feanil
force-pushed
the
feanil/test_on_3.11
branch
from
f433751
to
8a78701
Compare
feanil
force-pushed
the
feanil/test_on_3.11
branch
from
8a78701
to
b512f37
Compare
feanil
force-pushed
the
feanil/test_on_3.11
branch
4 times, most recently
from
d17340e
to
288cf40
Compare
Scipy was constrained to prevent a numpy upgrade however the numpy upgrade happened a while ago and this never got updated. Now the scipy version is preventing us from going to an even newer numpy version that would be compatible with both Python 3.8 and Python 3.12 BREAKING CHANGE: This will update scipy in the codejail sandbox from 1.7.3 to a newer version. This contains many backwards incompatible changes that are all documented in the SciPy changelogs: https://docs.scipy.org/doc/scipy/release/1.8.0-notes.html
Ran `package=scipy make upgrade-package` to upgrade just this one dependency.
BREAKING CHANGE: Because numpy is available in the codejail sandbox, the update from 1.22.4 to 1.24.4 does have completed deprecations, and more details can be found in the Numpy Release Notes: https://numpy.org/doc/stable/release/1.23.0-notes.html#expired-deprecations
We do this so that we can build requirements files that could work to `pip install` on both the old (3.8) and new (3.11) versions of python.
feanil
force-pushed
the
feanil/test_on_3.11
branch
from
288cf40
to
61a603c
Compare
* Update so tox will allow running on the new version. * Update so the hosted runner actually respects the python version in the matrix
feanil
force-pushed
the
feanil/test_on_3.11
branch
from
61a603c
to
325a7b9
Compare
This was referenced May 1, 2024
Closed
kdmccormick
approved these changes
May 1, 2024
| @@ -12,7 +12,7 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| python-version: [ '3.8', '3.12' ] | |||
| python-version: [ '3.8', '3.11', '3.12' ] | |||
There was a problem hiding this comment.
When the changes were coming into edx-platform we still thought we were going directly to 3.12 so that's why it was there in the first place. I left 3.12 in since otherwise I'll just have to add it in a future PR and this one is small enough that I'm not worried.
This was referenced May 2, 2024
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds testing for python 3.11 wherever possible alongside python 3.8.
Major updates include the unpinning and upgrade fo SciPy and Numpy in both the platform requirements as well as the codejail (edx-sandbox) requirements. If you are using the latest edx-sandbox/base.txt to operate codejail environments, this may break your instructor code that utilizes sci-py/numpy.