feat: add file size length to returned json #33068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristinAoki
requested review from
bszabo,
kenclary,
jesperhodge,
connorhaugh and
rayzhou-bit
connorhaugh
approved these changes
Aug 21, 2023
KristinAoki
deleted the
KristinAoki/add-asset-file-size-to-json-response
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
mehedikhan72
pushed a commit
to mehedikhan72/edx-platform
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an assets's length (aka file size) to the returned assets json. This change impacts Course Authors.
Supporting information
JIRA Ticket: TNL-10962
The file size of an asset needs to be returned with the asset info json. The file size will be used in the asset info modal.
Testing instructions
Use this branch of frontend-app-course-authoring for testing
Deadline
None
Other information
frontend-app-course-authoring PR #573 is dependent on this PR.