Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: float " " symbol in the preview_body #32484

Merged
merged 2 commits into from
Aug 24, 2023
Merged

fix: float " " symbol in the preview_body #32484

merged 2 commits into from
Aug 24, 2023

Conversation

DmytroAlipov
Copy link
Contributor

Description

The issue is with the preview_body field when formatting the post body. If there are multiple consecutive spaces in the body of a post, the space character is replaced with  .

Before:

screen_2

After:

screen_1

@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 16, 2023
@mphilbrick211
Copy link

Hi @asadazam93! Would you, or someone from @openedx/edx-infinity, be able to review/merge this for us? Thanks!

@DmytroAlipov DmytroAlipov mentioned this pull request Jul 4, 2023
Merged
@mphilbrick211
Copy link

Hi @asadazam93! Would you, or someone from @openedx/edx-infinity, be able to review/merge this for us? Thanks!

Hi @asadazam93 and @openedx/edx-infinity! Just following up on this.

@mphilbrick211
Copy link

Thanks so much, @AhtishamShahid! Are you able to merge this as well?

@AhtishamShahid AhtishamShahid merged commit fa45caa into openedx:master Aug 24, 2023
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awais-ansari awais-ansari awais-ansari approved these changes

@AhtishamShahid AhtishamShahid AhtishamShahid approved these changes

@asadazam93 asadazam93 Awaiting requested review from asadazam93

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DmytroAlipov @openedx-webhooks @mphilbrick211 @edx-pipeline-bot @AhtishamShahid @awais-ansari @e0d