-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styling fixes to file upload input in instructor dashboard #32330
Styling fixes to file upload input in instructor dashboard #32330
Conversation
Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Thanks for submitting this fix, @rpenido ! Your CSS changes look good, and your video screenshots are great. But could you add Testing Instructions that explain how to reach this screen? I don't see it in my Instructor Dashboard for the DemoX course, so there must be some kind of certificate enabling that I need to do first. Thanks! |
Thank you for your inputs @pomegranited! I updated the PR with the Could you please check if it is ok to remove the draft state? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 working great, thank you @rpenido !
However, you'll need to update your commit messages to conform to OEP-0051 otherwise the CI will fail -- e.g.,
fix: styles issue for the "Upload a CSV file" field on the Instructor Dashboard
Feel free to squash your commits at the same time and force push, and take this out of Draft.
- I tested this using the PR test instructions in both Firefox and Chrome
- I read through the code
- I checked for accessibility issues by using my keyboard only to use the modified UI components.
-
Includes documentationN/A
Hi @mphilbrick211 , @pkulkark said she could pick up this review as CC (thank you!). Can we let tests run here? |
@rpenido The changes look good. Would you mind rebasing your branch onto the latest master instead of merging? That would remove the unrelated commits. |
@pkulkark PR rebased! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rpenido. Just a small nit - the title can probably be changed to "styling fixes to file upload input in instructor dashboard" to better convey what's done here. Otherwise LGMT 👍
- I tested this: Verified the styling fixes works as described in the testing instructions
- I read through the code
- I checked for accessibility issues
-
Includes documentationN/A
@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
EdX Release Notice: This PR has been deployed to the production environment. |
Description
Fixing some issues with responsiveness and the field border, as show below:
Supporting information
Closes #32030
Testing instructions
ALLOW_AUTOMATED_SIGNUPS
, changing the feature value fromFalse
toTrue
edx-platform/lms/djangoapps/instructor/settings/common.py
Line 72 in cc9ec69
Instructor Dashboard
from the DemoX courseMembership
tabRegister/Enroll Students
section