Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling fixes to file upload input in instructor dashboard #32330

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Styling fixes to file upload input in instructor dashboard #32330

merged 1 commit into from
Jun 13, 2023

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented May 30, 2023

Description

Fixing some issues with responsiveness and the field border, as show below:
image

Supporting information

Closes #32030

Testing instructions

  • Enable ALLOW_AUTOMATED_SIGNUPS, changing the feature value from False to True
    'ALLOW_AUTOMATED_SIGNUPS': False,
  • Go to the Instructor Dashboard from the DemoX course
  • Open the Membership tab
  • The change is in the Register/Enroll Students section

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 30, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented May 30, 2023

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@pomegranited
Copy link
Contributor

Thanks for submitting this fix, @rpenido ! Your CSS changes look good, and your video screenshots are great.

But could you add Testing Instructions that explain how to reach this screen? I don't see it in my Instructor Dashboard for the DemoX course, so there must be some kind of certificate enabling that I need to do first. Thanks!

@rpenido
Copy link
Contributor Author

rpenido commented May 31, 2023

Thank you for your inputs @pomegranited! I updated the PR with the Testing Instructions.

Could you please check if it is ok to remove the draft state?

@rpenido rpenido changed the title Fix/file upload input instructor certificate page Fix: file upload input instructor certificate page Jun 1, 2023
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 working great, thank you @rpenido !

However, you'll need to update your commit messages to conform to OEP-0051 otherwise the CI will fail -- e.g.,

fix: styles issue for the "Upload a CSV file" field on the Instructor Dashboard

Feel free to squash your commits at the same time and force push, and take this out of Draft.

  • I tested this using the PR test instructions in both Firefox and Chrome
  • I read through the code
  • I checked for accessibility issues by using my keyboard only to use the modified UI components.
  • Includes documentation N/A

@rpenido rpenido changed the title Fix: file upload input instructor certificate page Fix: file upload input instructor certificate page WIP Jun 1, 2023
@rpenido rpenido changed the title Fix: file upload input instructor certificate page WIP Fix: file upload input instructor certificate page Jun 1, 2023
@rpenido rpenido marked this pull request as ready for review June 1, 2023 12:18
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 1, 2023
@pomegranited
Copy link
Contributor

pomegranited commented Jun 5, 2023

Hi @mphilbrick211 , @pkulkark said she could pick up this review as CC (thank you!). Can we let tests run here?

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 6, 2023
@pkulkark
Copy link
Contributor

pkulkark commented Jun 12, 2023

@rpenido The changes look good. Would you mind rebasing your branch onto the latest master instead of merging? That would remove the unrelated commits.

@rpenido
Copy link
Contributor Author

rpenido commented Jun 12, 2023

@pkulkark PR rebased!

Copy link
Contributor

@pkulkark pkulkark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rpenido. Just a small nit - the title can probably be changed to "styling fixes to file upload input in instructor dashboard" to better convey what's done here. Otherwise LGMT 👍

  • I tested this: Verified the styling fixes works as described in the testing instructions
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation N/A

@rpenido rpenido changed the title Fix: file upload input instructor certificate page Styling fixes to file upload input in instructor dashboard Jun 13, 2023
@pkulkark pkulkark merged commit 33e93a4 into openedx:master Jun 13, 2023
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@rpenido rpenido deleted the fix/file-upload-input-instructor-certificate-page branch June 26, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cc-reviewer open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix styling issue in the instructor dashboard
8 participants