fix: removing deprecated XBlock from reququirements #31158
Conversation
There was a problem hiding this comment.
Thanks for the PR Ed. In order to apply these changes to the .txt, files, can you either:
- run
tutor dev run --mount=path/to/edx-platform lms make upgradeand commit the result, or - just update the requirements/edx/*.txt files by hand to remove RateXBlock?
Technically, we could just merge this as-is and let the requirements bot update the .txt files automatically, but that makes change tracing a bit more difficult, since the removal would occur not under this commit message but under an inconspicuous "chore: upgrade requirements" commit message.
|
Oh, and to indicate the breaking change, please use the |
|
Please ignore the mention, I tagged a wrong PR by mistake. Sorry for the noise. |
e0d
force-pushed
the
e0d/remove-rate-xblock
branch
from
4292bd0
to
3eb610a
Compare
requirements/common_constraints.txt
Outdated
| # This is a temporary solution to override the real common_constraints.txt | ||
| # In edx-lint, until the pyjwt constraint in edx-lint has been removed. | ||
| # See BOM-2721 for more details. | ||
| # Below is the copied and edited version of common_constraints |
There was a problem hiding this comment.
I bet make upgrade pulled this in. I have the same change on another PR of mine that involved running make upgrade.
|
There's also a |
🤯 |
|
Alternatively, you can remove the |
| -e git+https://github.com/openedx/RateXBlock.git@2.0.1#egg=rate-xblock | ||
| # via -r requirements/edx/github.in |
There was a problem hiding this comment.
You'll also want to remove this from testing.txt and development.txt.
|
Hmm, it looks like there might still be a couple instances of this on edx.org -- need to check on that before merging. |
|
|
I've found a couple of old course runs still using this. Any idea what happens if the XBlock is uninstalled and someone tries to interact with those courses? |
|
@ormsbee Do you know the answer to Tim's question? |
There was a problem hiding this comment.
Looks like we're good to go on the edx.org side of things!
It's only used in a couple of courses, and even then only in a section hidden from students. My only concern was that it might break the learning or editing experience, but I did a test on devstack, and it's handled gracefully enough: The block is displayed as being in error in Studio (but the vertical can still be edited) and is simply not rendered on LMS.
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Description
This PR removes a dependency that has been deprecated and move to openedx-unsupported.
Redirects will work in the meantime, but we should remove the reference here to the deprecated XBlock.