Remove or contextualize references to edX.org in translated strings
#28638
Conversation
sarina
force-pushed
the
sarina/abstract-branded-url-strings
branch
from
ee410e4 to
3b43606
Compare
sarina
force-pushed
the
sarina/abstract-branded-url-strings
branch
from
ca8bbd4 to
540c97c
Compare
sarina
changed the title
edX.org in translated strings
| @@ -4,14 +4,14 @@ | |||
| This is the RED theme! | |||
| {% if course_ids|length > 1 %} | |||
| {% blocktrans trimmed %} | |||
| Remember when you enrolled in {{ course_name }}, and other courses on edX.org? We do, and we’re glad | |||
| Remember when you enrolled in {{ course_name }}, and other courses on {{ platform_name }}? We do, and we’re glad | |||
There was a problem hiding this comment.
This is a template used in an example theme. I changed to using {{ platform_name }} to match exactly other usages of this string, to simplify translator burden.
| @@ -34,8 +35,9 @@ <h1> | |||
|
|
|||
| %endif | |||
| <br><br> | |||
| ${Text(_("{link_start}Return to edX.org{link_end}")).format( | |||
| link_start=HTML("<u> <a href='https://www.edx.org/'>"), | |||
| ${Text(_("{link_start}Return to {platform_name}{link_end}")).format( | |||
There was a problem hiding this comment.
I am speaking with @cc-okoro about the impact of changing this, the sole usage of edX.org hardcoded where it shouldn't be, to using the already-abstracted platform_name
There was a problem hiding this comment.
I did some sleuthing for this page on edx.org and found that it's an unused page as edX has switched to Braze.
sarina
force-pushed
the
sarina/abstract-branded-url-strings
branch
from
aa05b4b to
a6616fd
Compare
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Description
In order to properly internationalize all strings for Open edX, remove references to
edX.orgthat is hardcoded in strings so that Open edX installations to not contain references back to the edX main site.Additionally, add some translators comments for strings we ONLY use on edX.org, so Open edX site operators working on translations understand why the strings are not abstracted, and contextualize one string that references edX.org that should appear on Open edX installations.
Supporting information
Brought up by Pierre in Transifex Working Group. Doing this work on behalf of them
Testing instructions
Need to test by figuring out how to manually pull up the template
lms/templates/bulk_email/unsubscribe_success.htmlto make sure variables are inserted properly.Deadline
Oct 8 (Maple)