ENT-4095: Handle coupon expiration date scenario in LMS #27704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed some issues fixed failing test cases and pylint failures fixed failing refund signal tests fixed pylint failures added test cases and fixed some issues with code fixed-failing-test incorporated feedback fixed typo in docstring
sameenfatima78
requested review from
saleem-latif,
zamanafzal,
irfanuddinahmad and
muhammad-ammar
|
Your PR has finished running tests. There were no failures. |
saleem-latif
approved these changes
May 24, 2021
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage |
|
EdX Release Notice: This PR has been deployed to the production environment. |
blarghmatey
pushed a commit
to mitodl/edx-platform
that referenced
this pull request
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JIRA: https://openedx.atlassian.net/browse/ENT-4095
This PR handles coupon code expiration scenario in case of a course refund. The changes in this PR will make sure that a user does not receive an email with an expired voucher in case the coupon batch has already expired. Also, the message displayed on frontend is going to be different in both cases.
Voucher not expired:
Voucher expired:
Useful information to include:
"Developer", and "Operator".
changes.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.