fix: fix typo that prevented video completion working as intended #27230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neither of these settings were being correctly set: * COMPLETION_BY_VIEWING_DELAY_MS * COMPLETION_VIDEO_COMPLETE_PERCENTAGE AA-743
mikix
force-pushed
the
mikix/video-completion-typo
branch
from
3b0f488
to
5169d70
Compare
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
@nedbat, could this be cherry-picked to |
|
I've cherry-picked this to koa.master. koa.3 is a tag and cannot be changed. |
regisb
referenced
this pull request
in overhangio/tutor
May 17, 2021
- [Security] Apply Django security patches by upgrading from 2.2.20 to 2.2.23. - [Bugfix] Fix video unit completion (see [pull request](https://github.com/edx/edx-platform/pull/27230)).
regisb
referenced
this pull request
in overhangio/tutor
May 17, 2021
- [Security] Apply Django security patches by upgrading from 2.2.20 to 2.2.23. - [Bugfix] Fix video unit completion (see [pull request](https://github.com/edx/edx-platform/pull/27230)).
regisb
referenced
this pull request
in overhangio/tutor
May 17, 2021
- [Security] Apply Django security patches by upgrading from 2.2.20 to 2.2.23. - [Bugfix] Fix video unit completion (see [pull request](https://github.com/edx/edx-platform/pull/27230)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither of these settings were being correctly set:
https://openedx.atlassian.net/browse/AA-743