Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAN-392: suppress PII from logistration error messages #26629

Merged

Conversation

zainab-amir
Copy link
Contributor

On register page, when user enters a username and/or email that already exists in the platform. the error is generated on

  • field focus out
  • submit "Create Account"

and error is displayed below the form field and on top of the page in alert box saying that this username/email already exists.This is being captured in hotjar recordings of this page.

Note:

Suppressed username and email validation errors to avoid sending PII to hotjar

Copy link
Contributor

@waheedahmed waheedahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take the suggestion or you can leave it as it is.

@zainab-amir zainab-amir force-pushed the zamir/VAN-392/add_data_hj_suppress_to_validation_error branch from dda4184 to 6ac863b Compare February 19, 2021 12:32
@zainab-amir zainab-amir force-pushed the zamir/VAN-392/add_data_hj_suppress_to_validation_error branch from 6ac863b to 91ee118 Compare February 19, 2021 13:27
@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@zainab-amir zainab-amir merged commit 0150133 into master Feb 19, 2021
@zainab-amir zainab-amir deleted the zamir/VAN-392/add_data_hj_suppress_to_validation_error branch February 19, 2021 14:04
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants