Fixed change language acceptance test #2630
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 25, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 31, 2019
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jan 31, 2019
kdmccormick
pushed a commit
to kdmccormick/edx-platform
that referenced
this pull request
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After changing the language, the dashboard automatically refreshes.
However, unless we explicitly tell the tests to visit the dashboard, we run the risk of trying to look at the text on the dashboard before the page has finished refreshing.
This fix forces the test to explicitly visit the dashboard before checking for text.
@wedaly , let me know if my surmising here is actually correct?