Use full names for lms.djangoapps imports

[kdmccormick]

Overview

Part of the sys.path modification removal & cleanup, started by https://github.com/edx/edx-platform/pull/24616 . See the ADR for details.

This PR fixes all imports of LMS djangoapps to use the preferred style (import lms.djangoapps.myapp..) instead of the deprecated short version (import myapp...). It also un-silences the deprecated-import warnings so that we can see whether any installed packages are using the deprecated imports. Each LMS djangoapp's imports are fixed in their own commit.

Related, rename sys_path_hacks to import_shims [MERGED]

Next up, remove sys.path hack for common/djangoapps.

Desired end goal

• No sys path hacks warnings on devstack LMS startup.

• If possible, having this canary PR without the imports shims get a green build, indicating that all tested old-style imports were fixed.

General approach

I repeated the following approach for each top-level folder in lms/djangoapps, notated here as {APPNAME}:

First, replace from {APPNAME} import {X} with from lms.djangoapps.{APPNAME} import {X}. Using Sublime Text Find+Replace:

Find:
^( *)from {APPNAME}\b
Replace:
\1from lms.djangoapps.{APPNAME}

Then, search for instances of import {APPNAME}...

Find:
^( *)import {APPNAME}\b

and manually fix them. The manual fixes are required here because import without from or as causes the module to imported with its qualified name, so changing the qualified name requires also changing code in the module.

Finally, search for references to the old import path by string (patches, INSTALLED_APPS, etc.):

Find:
(['"]){APPNAME}\b

and comb through the output, fixing any references to the old import path. This involves making judgement calls as to what is an import path versus something different (like, a cache key or URL name).

isort

Sorting imports as part of this PR isn't necessary, but it should make the import block much more readable, especially now that many of the names have changed and any previous manual alphabetization efforts have been messed up.

So, I'm going to include one big isort commit at the end isort everything in a PR after this one.

(In the CMS PR, I was able to sort import within cms/ without only some minor isort:skip additions, but that folder much smaller and less magic-filled than lms/, common/, and openedx/.)

[kdmccormick]

jenkins run python

[edx-status-bot]

Your PR has finished running tests. There were no failures.

[kdmccormick]

FYI @davidjoy. I expect this to be on prod around 9:45; I'll be keeping a close eye on it.

[edx-pipeline-bot]

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

[edx-pipeline-bot]

EdX Release Notice: This PR has been deployed to the production environment.