A modal used to collect demographics information #24956
Conversation
Tj-Tracy
force-pushed
the
ttracy/demographics_modal
branch
from
36067f3 to
6ce5e0d
Compare
Add checkmark to final page (#24957) Remove themeing to get ready for staging MICROBA-574 | Dismiss CTA after learner finishes answering modal questions (#24965) MICROBA-574 | Dismiss CTA after learner finishes answering demographics questions [MICROBA-574] - Dismiss CTA after learner finishes answering demographics questions - Cleanup comments Add back devstack logging Remove keys new line
Tj-Tracy
force-pushed
the
ttracy/demographics_modal
branch
from
07c7443 to
d52e313
Compare
* Various initial bugfixes - fixes 2 issues with the multiselect dropdown erasing state - prevents input higher than 255 characters in the self describe - fixes 400 errors when the user selects a default option - Removes additional page count section
[MB-312] - Re-adding deleted JS file. Can't clean this up until after we cutover to using the new Demographics modal
| @@ -1,56 +1,196 @@ | |||
| .modal-open { | |||
There was a problem hiding this comment.
Is everything left here styling we could not convert to utility classes? Or is the CSS cleanup still something we need to do in a future release?
There was a problem hiding this comment.
CSS cleanup is going to have to happen at some point. There are still things I have not yet transferred over.
| /** | ||
| * Utils file to support JWT Token Authentication. | ||
| * | ||
| * Temporarily copied from the edx/frontend-platform |
There was a problem hiding this comment.
"Temporary" caught my eye. Is there any follow up work we need to do here? If so, is it captured in a ticket in the backlog anywhere?
There was a problem hiding this comment.
HAH! Disregard. I was reviewing this PR from the bottom to the top. I see we added that README above when we pulled this code in. So it sounds like this is taken care of =D
There was a problem hiding this comment.
Yup. Please see the README.
MB-312 | Demographics modal bugfix
| </div> | ||
| ) | ||
| } else { | ||
| return null; |
There was a problem hiding this comment.
Is null the right response here?
There was a problem hiding this comment.
Yes, when you don't want to render anything in react, you return null in the render.
lms/static/js/demographics_collection/DemographicsCollectionModal.jsx
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,77 @@ | |||
| /** | |||
There was a problem hiding this comment.
Note: Copied file from frontend-platform.
| @@ -0,0 +1,124 @@ | |||
| /** | |||
There was a problem hiding this comment.
Note: Copied file from frontend-platform with minimal. Please see README.
| /** | ||
| * Utils file to support JWT Token Authentication. | ||
| * | ||
| * Temporarily copied from the edx/frontend-platform |
There was a problem hiding this comment.
Yup. Please see the README.
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
[APER-2823] Removes React compoents and functionality tied to a private 2U/edx.org-specific Demographics IDA from edx-platform. This PR attempts to remove everything added from this PR: #24956. This includes the React components created to collect and transmit Demographics data, as well as functionality for managing JWT and CSRF tokens copied from `frontend-platform` to edx-platform when originally implementing the CTA and modal components.
) [APER-2823] Removes React compoents and functionality tied to a private 2U/edx.org-specific Demographics IDA from edx-platform. This PR attempts to remove everything added from this PR: #24956. This includes the React components created to collect and transmit Demographics data, as well as functionality for managing JWT and CSRF tokens copied from `frontend-platform` to edx-platform when originally implementing the CTA and modal components.
…nedx#35121) [APER-2823] Removes React compoents and functionality tied to a private 2U/edx.org-specific Demographics IDA from edx-platform. This PR attempts to remove everything added from this PR: openedx#24956. This includes the React components created to collect and transmit Demographics data, as well as functionality for managing JWT and CSRF tokens copied from `frontend-platform` to edx-platform when originally implementing the CTA and modal components.
…nedx#35121) [APER-2823] Removes React compoents and functionality tied to a private 2U/edx.org-specific Demographics IDA from edx-platform. This PR attempts to remove everything added from this PR: openedx#24956. This includes the React components created to collect and transmit Demographics data, as well as functionality for managing JWT and CSRF tokens copied from `frontend-platform` to edx-platform when originally implementing the CTA and modal components.
No description provided.