Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAN-3: Add mechanism to enable logistration MFE #24908

Merged

Conversation

zainab-amir
Copy link
Contributor

Add a toggle that in conjunction with REDIRECT_TO_ACCOUNT_MICROFRONTEND enables or disables logistration MFE.

Notes:

  • Added setting variable LOGISTRATION_MICROFRONTEND_URL to point to logistration url (which for now is same as ACCOUNT_MICROFRONTEND_URL as the code will be part of Accounts MFE)
  • Added feature setting ENABLE_LOGIN_MICROFRONTEND

Ticket: VAN-3

@zainab-amir
Copy link
Contributor Author

jenkins run python

@zainab-amir
Copy link
Contributor Author

jenkins run python

Copy link
Contributor

@waheedahmed waheedahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, 👍 once addressed.

Add a toggle that in conjuction with REDIRECT_TO_ACCOUNT_MICROFRONTEND
enables or disables logistration MFE.

VAN-3
@zainab-amir zainab-amir force-pushed the zamir/VAN-3/add_mechanism_to_enable_logistration_mfe branch from b19b7d5 to 31144d0 Compare September 8, 2020 09:53
@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@zainab-amir zainab-amir merged commit 8f83d10 into master Sep 8, 2020
@zainab-amir zainab-amir deleted the zamir/VAN-3/add_mechanism_to_enable_logistration_mfe branch September 8, 2020 12:46
@zainab-amir zainab-amir restored the zamir/VAN-3/add_mechanism_to_enable_logistration_mfe branch September 8, 2020 12:46
@zainab-amir zainab-amir deleted the zamir/VAN-3/add_mechanism_to_enable_logistration_mfe branch September 8, 2020 12:46
@zainab-amir zainab-amir restored the zamir/VAN-3/add_mechanism_to_enable_logistration_mfe branch September 8, 2020 12:46
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@zainab-amir zainab-amir deleted the zamir/VAN-3/add_mechanism_to_enable_logistration_mfe branch September 9, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants