Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to the new version of paragon in the new scope. #2099

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Oct 31, 2023

Part of openedx/axim-engineering#23

This replaces the @edx/paragon packag to point to the paragon package at
the openedx scope(@openedx/paragon). Imports have been updated to use the
same locations in the new package.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (337c68b) 94.95% compared to head (1a925e7) 94.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2099   +/-   ##
=======================================
  Coverage   94.95%   94.95%           
=======================================
  Files         191      191           
  Lines       20518    20518           
  Branches     1859     1859           
=======================================
  Hits        19482    19482           
  Misses        776      776           
  Partials      260      260           
Flag Coverage Δ
unittests 94.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feanil feanil force-pushed the feanil/update_paragon_dependency branch 2 times, most recently from 6e18f76 to 8cb690a Compare October 31, 2023 12:31
@brian-smith-tcril
Copy link

looks like this line needs to be changed

@import '@edx/paragon/scss/core/core.scss';

@feanil feanil force-pushed the feanil/update_paragon_dependency branch from 8cb690a to 4ecf3bf Compare November 1, 2023 12:47
@feanil feanil force-pushed the feanil/update_paragon_dependency branch 2 times, most recently from 41cea4a to 388d850 Compare December 7, 2023 15:26
@feanil feanil marked this pull request as ready for review December 11, 2023 19:44
@feanil feanil requested a review from a team as a code owner December 11, 2023 19:44
Part of openedx/axim-engineering#23

This replaces the `@edx/paragon` packag to point to the `paragon` package at
the `openedx` scope(`@openedx/paragon`). Imports have been updated to use the
same locations in the new package.
This babel-loader config is pulled from frontend-build@13.0.4

We had to do this because frontend-build is currently too far behind and
can't easily be updated to a newer version without upgrading webpack and
many other libraries.

By making this small change we unblock the paragon upgrade to the new
scope and latest version.
This is now best practice in repos with JS code so that it's easy to be
using the right version of node.  This repo is still on node 16 because
edx-platform is still on node 16
@feanil feanil force-pushed the feanil/update_paragon_dependency branch from a0ed070 to 1a925e7 Compare December 11, 2023 19:49
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mattcarter mattcarter merged commit de776f8 into master Dec 19, 2023
9 checks passed
@mattcarter mattcarter deleted the feanil/update_paragon_dependency branch December 19, 2023 15:33
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this pull request Feb 6, 2024
…x#2099)

* chore: Update to the new version of paragon in the new scope.

Part of openedx/axim-engineering#23

This replaces the `@edx/paragon` packag to point to the `paragon` package at
the `openedx` scope(`@openedx/paragon`). Imports have been updated to use the
same locations in the new package.

* fix: Update webpack configs to transpile openedx packages.

This babel-loader config is pulled from frontend-build@13.0.4

We had to do this because frontend-build is currently too far behind and
can't easily be updated to a newer version without upgrading webpack and
many other libraries.

By making this small change we unblock the paragon upgrade to the new
scope and latest version.

* chore: Static asset compilation.

* build: Add an nvmrc file to be clear about the node version.

This is now best practice in repos with JS code so that it's easy to be
using the right version of node.  This repo is still on node 16 because
edx-platform is still on node 16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants