-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update to the new version of paragon in the new scope. #2099
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2099 +/- ##
=======================================
Coverage 94.95% 94.95%
=======================================
Files 191 191
Lines 20518 20518
Branches 1859 1859
=======================================
Hits 19482 19482
Misses 776 776
Partials 260 260
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6e18f76
to
8cb690a
Compare
looks like this line needs to be changed
|
8cb690a
to
4ecf3bf
Compare
41cea4a
to
388d850
Compare
Part of openedx/axim-engineering#23 This replaces the `@edx/paragon` packag to point to the `paragon` package at the `openedx` scope(`@openedx/paragon`). Imports have been updated to use the same locations in the new package.
This babel-loader config is pulled from frontend-build@13.0.4 We had to do this because frontend-build is currently too far behind and can't easily be updated to a newer version without upgrading webpack and many other libraries. By making this small change we unblock the paragon upgrade to the new scope and latest version.
This is now best practice in repos with JS code so that it's easy to be using the right version of node. This repo is still on node 16 because edx-platform is still on node 16
a0ed070
to
1a925e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
…x#2099) * chore: Update to the new version of paragon in the new scope. Part of openedx/axim-engineering#23 This replaces the `@edx/paragon` packag to point to the `paragon` package at the `openedx` scope(`@openedx/paragon`). Imports have been updated to use the same locations in the new package. * fix: Update webpack configs to transpile openedx packages. This babel-loader config is pulled from frontend-build@13.0.4 We had to do this because frontend-build is currently too far behind and can't easily be updated to a newer version without upgrading webpack and many other libraries. By making this small change we unblock the paragon upgrade to the new scope and latest version. * chore: Static asset compilation. * build: Add an nvmrc file to be clear about the node version. This is now best practice in repos with JS code so that it's easy to be using the right version of node. This repo is still on node 16 because edx-platform is still on node 16
Part of openedx/axim-engineering#23
This replaces the
@edx/paragon
packag to point to theparagon
package atthe
openedx
scope(@openedx/paragon
). Imports have been updated to use thesame locations in the new package.