Prefix edx-platform/common/djangoapps imports with 'common.djangoapps' #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdmccormick
force-pushed
the
kdmccormick/sys-path-hacks-common
branch
from
b52f7bf to
b7334e4
Compare
morenol
approved these changes
Nov 20, 2020
Previously, code from these djangoapps could be imported without the 'common.djangoapps' prefix. For example, one could write 'from student import models' intead of 'from common.djangoapps.student import models'. This import pattern unidiomatic and is now deprecated. See edx-platform/docs/decisions/0007-sys-path-modification-removal.rst for details and justification.
kdmccormick
force-pushed
the
kdmccormick/sys-path-hacks-common
branch
from
b7334e4 to
af837ef
Compare
iloveagent57
approved these changes
Nov 25, 2020
sameenfatima78
pushed a commit
that referenced
this pull request
Dec 1, 2020
#1036) Previously, code from these djangoapps could be imported without the 'common.djangoapps' prefix. For example, one could write 'from student import models' intead of 'from common.djangoapps.student import models'. This import pattern unidiomatic and is now deprecated. See edx-platform/docs/decisions/0007-sys-path-modification-removal.rst for details and justification.
sameenfatima78
pushed a commit
that referenced
this pull request
Dec 1, 2020
…in enterprise report configurations. added validation to set these reports for pearson only. Refresh catalog metadata on create and update (#1032) ENT-3531 update edx-django-utils>=3.12.0 We need edx-django-utils>=3.12.0 for the new decorator for code_owner for celery tasks. ARCHBOM-1260 add code_owner for celery tasks Celery tasks need an additional decorator to track code ownership. ARCHBOM-1260 remove DeprecatedEdxPlatformImportWarning in utils remove DeprecatedEdxPlatformImportWarning in admin remove DeprecatedEdxPlatformImportWarning signals Bug fix: enterprise catalog api raise exception Prefix edx-platform/common/djangoapps imports with 'common.djangoapps' (#1036) Previously, code from these djangoapps could be imported without the 'common.djangoapps' prefix. For example, one could write 'from student import models' intead of 'from common.djangoapps.student import models'. This import pattern unidiomatic and is now deprecated. See edx-platform/docs/decisions/0007-sys-path-modification-removal.rst for details and justification. ENT-3591: update EnterpriseProxyLoginView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, code from these djangoapps could be imported without
the 'common.djangoapps' prefix. For example, one could write
'from student import models' intead of
'from common.djangoapps.student import models'.
This import pattern unidiomatic and is now deprecated. See
edx-platform/docs/decisions/0007-sys-path-modification-removal.rst
for details and justification.
Related to https://github.com/edx/edx-platform/pull/25477
Update -- People are seeing this error on Devstack:
I believe this PR would resolve that error.