Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: fix course detail page url bug #4033

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix!: fix course detail page url bug #4033

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0e008e
fix!: fix course detail page url bug
Sep 25, 2023
5b1fde3
docs!: add a comment
Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ecommerce/static/js/models/course_model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ define([

return Backbone.RelationalModel.extend({
urlRoot: '/api/v2/courses/',
// course detail page url was not matching because of missing trailing slash,
// with thi function, trailing slash will be added to match the url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// with thi function, trailing slash will be added to match the url
// with this function, trailing slash will be added to match the url

url: function() {
Faraz32123 marked this conversation as resolved.
Show resolved Hide resolved
return Backbone.Model.prototype.url.call(this) + '/';
},

defaults: {
id: null,
Expand Down
Loading