-
Notifications
You must be signed in to change notification settings - Fork 3
Drop Python 3.8 & add support for Python 3.12 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ttqureshi
commented
Apr 22, 2025
- resolves: Drop Python 3.8 & Add Support for Python 3.12 #11
- drop support for python 3.8
Encountering this error because |
| # Start of the command to run the compiler in Java. | ||
| return [ | ||
| "java", | ||
| "--add-exports", "java.base/sun.nio.ch=ALL-UNNAMED", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this need to be added? Can you add a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feanil
before making this change, I was getting the following error:
class org.mozilla.javascript.MemberBox cannot access class sun.nio.ch.FileChannelImpl
(in module java.base) because module java.base does not export sun.nio.ch to unnamed module
The --add-exports flag allows Rhino to access Java’s internal sun.nio.ch package, which is restricted by default in Java 9+ due to the module system. Without it, Rhino fails when trying to perform file operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, please add this as a comment in the file above this line so we can have it as reference if anyone asks the same question in the future.
feanil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small changes and then hopefully this is good to merge and release.
| # Start of the command to run the compiler in Java. | ||
| return [ | ||
| "java", | ||
| "--add-exports", "java.base/sun.nio.ch=ALL-UNNAMED", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, please add this as a comment in the file above this line so we can have it as reference if anyone asks the same question in the future.