Fix model permissions for UserCredential. #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimabramson
force-pushed
the
jsa/ecom-3978
branch
2 times, most recently
from
2c2d8fd
to
c6be5d7
Compare
| The creation (POST) method requires the 'add' permission. | ||
| """ | ||
| list_path = reverse('api:v1:usercredential-list') | ||
| program_certificate = factories.ProgramCertificateFactory(program_id=2) |
There was a problem hiding this comment.
Is it necessary to provide the program_id kwarg here?
jimabramson
force-pushed
the
jsa/ecom-3978
branch
from
c6be5d7
to
e0ab128
Compare
|
👍 |
1 similar comment
|
👍 |
|
Besides a question, rest LGTM |
jimabramson
force-pushed
the
jsa/ecom-3978
branch
from
e0ab128
to
de9cd9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECOM-3978
@ahsan-ul-haq @awais786 @rlucioni please review.