[BD-6] OEP-18 Compliance #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create requirements folder. create pip_tools and base requirements files. Add Makefile. Add makefile upgrade command. Include requirements files generated using upgrade command. Update openedx.yaml OEPs list.
|
Thanks for the pull request, @ericfab179! I've created OSPR-4767 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
needs triage
open-source-contribution
morenol
approved these changes
Jun 29, 2020
mraarif
approved these changes
Jun 30, 2020
|
@ericfab179 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
openedx-webhooks
added
blended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add setup.py install_requirements definition.
Create requirements folder.
create pip_tools and base requirements files.
Add Makefile.
Add makefile upgrade command.
Include requirements files generated using upgrade command.
Update openedx.yaml OEPs list.
Since it does not have tests, its functionality was successfully tried in a devstack environment using python 3.8.
Reviewers