python3 compatibility #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noraiz-anwar
force-pushed
the
noraiz/PROD-771
branch
from
4095e80 to
71e5dc5
Compare
waheedahmed
approved these changes
Oct 8, 2019
waheedahmed
left a comment
waheedahmed
left a comment
There was a problem hiding this comment.
Can we integrate Pylint and Pep8 and test the code quality on travis at least? Otherwise 👍
openedx.yaml
Outdated
Contributor
Author
There was a problem hiding this comment.
I am not sure about the owner of this? Is there any way of finding that out?
Thanks.
There was a problem hiding this comment.
@noraiz-anwar I think pmitros but not sure otherwise you can just add unknown.
Contributor
Author
|
@waheedahmed Thanks for having a look. Integrating Pylint and Pep8 sounds a good idea. I'll surely discuss this with the reporter (Farhana) of the ticket to see if this integration can be covered in the scope of current work. |
noraiz-anwar
force-pushed
the
noraiz/PROD-771
branch
from
71e5dc5 to
57e6c62
Compare
awaisdar001
approved these changes
Oct 22, 2019
noraiz-anwar
force-pushed
the
noraiz/PROD-771
branch
from
57e6c62 to
4444437
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openedx.atlassian.net/browse/PROD-771