feat: Introduce Fast-Track DEPR Template #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdmccormick
force-pushed
the
kdmccormick/fast-track-depr
branch
from
ff82866 to
3bbcdf7
Compare
kdmccormick
requested review from
dianakhuang,
feanil,
robrap and
wgu-taylor-payne
Contributor
|
robrap
reviewed
Jun 12, 2025
| @@ -0,0 +1,40 @@ | |||
| name: 🚅 Fast-Track Deprecation/Removal (DEPR) | |||
| description: Per OEP-21, use this template when you are making a pre-approved breaking change. These include: Pre-planned upgrade tasks, removal of unreachable code, and subtasks of other approved DEPR tickets. Consult the DEPR Working Group if unsure. | |||
Contributor
There was a problem hiding this comment.
See #174 (comment) for request for an issue on this topic, until OEP-21 can be updated. The issue can refer to OEP-21. The new issue can be inserted into the text below in some nicely readable format.
Suggested change
| description: Per OEP-21, use this template when you are making a pre-approved breaking change. These include: Pre-planned upgrade tasks, removal of unreachable code, and subtasks of other approved DEPR tickets. Consult the DEPR Working Group if unsure. | |
| description: Use this template when you are making a pre-approved breaking change. These include: Pre-planned upgrade tasks, removal of unreachable code, and subtasks of other approved DEPR tickets. Consult the DEPR Working Group if unsure. See [Fast/Track DEPR proof-of-concept ticket](<insert issue>) for details. |
| @@ -1,4 +1,4 @@ | |||
| name: 🌘 Deprecation and Removal (DEPR) Ticket | |||
Contributor
There was a problem hiding this comment.
Note: The term "ticket" is used in the OEP. Is there an expected follow-up to change that?
Co-authored-by: Taylor Payne <taylor.payne@wgu.edu>
kdmccormick
force-pushed
the
kdmccormick/fast-track-depr
branch
from
54e0a31 to
126df46
Compare
Co-authored-by: Robert Raposa <rraposa@edx.org>
kdmccormick
commented
Jun 12, 2025
kdmccormick
commented
Jun 12, 2025
Member
Author
|
Comments addressed. Please LMK if you have any more blocking suggestions. I'm looking to get this merged soon so I can start using it, but I do plan to open another PR to clean up the language on both templates a bit. Happy to take nit-picks over there. |
robrap
approved these changes
Jun 12, 2025
wgu-taylor-payne
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Fast-Track DEPR issue template as described in #175
https://github.com/openedx/.github/blob/kdmccormick/fast-track-depr/.github/ISSUE_TEMPLATE/depr-ticket-fast-track.yml